From: Keenan T. <kt...@go...> - 2004-10-22 05:18:49
|
> However, the following is still broken: > * upgrades from any previous version and presumably the import tools > * actually displaying any content after the install Okay, I'm going to try to find some time this weekend, if things aren't too crazy, to get some hacking done. The other thing I thought I'd mention is that the MD5() function isn't present in Postgres before 7.4...and as far as I know all current versions of RedHat ship with 7.2. It's easy to do, but I think we should move all that stuff over to PHP's md5 function instead to improve the usefulness of this code. > Some of the enum substitution stuff you had done previously got lost > when the schema info moved to a new file. Still need to go back and > actually put a check on those to enforce the choices properly. Several > "enum('y','n')" and similar things I've changed into PgSQL's Boolean > type. It takes y, n, yes, no, 1, and 0 which seem to be the usually > suspects on those fields, and it should be a bit more efficient for > lookups. We may as well take this opportunity to make the non-boolean enums into a proper relational type, perhaps we can even utilise Postgres' powerful (so I'm told) custom types. Text comparison might be faster, but I sorta doubt it, and it's counter-intuitive. The proliferation of MySQLisms in the WordPress code is rather disheartening. I would've hoped such lauded code would be more consistent and 'correct'. Not a huge job to change though. Good to see some testing on PHP 5. Haven't had much chance to experiment with it yet. Also, my internet still seems a bit flaky here. The phone company, of course, denies responsibility. If you get e-mails bounced back or anything, just resend them, the outages only last a few minutes. -- Keenan Tims kt...@go... PGP: http://www.gotroot.ca/pubkey.asc |