From: Joshua P. <jos...@ma...> - 2008-07-29 13:59:34
|
I don't think it's hard to understand, but Migrations weren't in er.extensions before. I'm certain you took great care in the refactoring, as, well, you're Anjo. I was just digging through my Properties file looking for er.extensions.ERX* and noticed the Migration difference. On Jul 28, 2008, at 11:19 PM, Anjo Krank wrote: > Is this really so easy to misunderstand? > > When you set a class's name with the properties, you need to check > these classes if they were in the ERX package. Localizers, the JDBC > adaptor and probably a few others. This has *nothing* to do with the > namespacing of the property keys, which is another issue in itself. I > took a lot of care to morph any > > foo =ERXProps.propertyKorKey(ERXBla.class.getName()+ ".bar") > > to use the explicit "er.extensions.ERXBla.bar" instead. (Great care > means I may have missed some, though) > > Cheers, Anjo > > Am 29.07.2008 um 07:20 schrieb Joshua Paul: > >> Also...what about Migrations? >> >> er.migration.migrateAtStartup >> vs. >> er.extensions.migration.ERXMigrator.shouldMigrateAtStartup >> >> etc.??? >> >> Which is the "correct" approach? >> >> On Jul 24, 2008, at 8:36 PM, Anjo Krank wrote: >>> >>> Am 24.07.2008 um 22:37 schrieb Kieran Kelleher: >>> >>>> I was reading Mike's blog post at >>>> http://projectwonder.blogspot.com/2008/06/this-week-in-project-wonder.html >>> >>>> and see the warning about property names. I am checking the usage >>>> of >>>> er.extensions.className.* properties and those property strings >>>> seem >>>> to not have changed ..... are those property strings going to be >>>> changed in the future ...... is it something I should check each >>>> time >>>> I update to a newer version of Wonder? >>> >>> The post says: >>> >>> "check any xxx.className property which has a er.extensions thing in >>> it" >>> >>> which meant stuff like >>> >>> er.extensions.ERXJDBCAdaptor.className=er.extensions.JDBCAdaptor >>> >>> which was actually in the bugtracker and should now be: >>> >>> er.extensions.ERXJDBCAdaptor.className=er.extensions.eof.JDBCAdaptor >>> >>> (or whatever). >>> >>> The properties are namespaced already, so we might have done away >>> with >>> the er.extenions prefix, but all other java stuff seems to have >>> it... >>> >>> I actually went through all code and checked all the >>> System.getPoperty(getClass().getName()) stuff to explicit names. >>> This >>> should actually be an anti-pattern, I have a huge code base that >>> uses >>> this and it royally suckes when refactoring. Likewise for fully >>> named >>> DAs, btw (.../wa/er.extenions.ERXDirectAction). >>> >>> Cheers, Anjo >>> >>> >>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's >>> challenge >>> Build the coolest Linux based applications with Moblin SDK & win >>> great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in >>> the world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> _______________________________________________ >>> Wonder-disc mailing list >>> Won...@li... >>> https://lists.sourceforge.net/lists/listinfo/wonder-disc >> >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's >> challenge >> Build the coolest Linux based applications with Moblin SDK & win >> great prizes >> Grand prize is a trip for two to an Open Source event anywhere in >> the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ >> Wonder-disc mailing list >> Won...@li... >> https://lists.sourceforge.net/lists/listinfo/wonder-disc > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win > great prizes > Grand prize is a trip for two to an Open Source event anywhere in > the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Wonder-disc mailing list > Won...@li... > https://lists.sourceforge.net/lists/listinfo/wonder-disc |