wix-devs — Windows Installer XML toolset developer mailing list

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Bob A. <bo...@jo...>]

On 02-Feb-15 15:20, Tunney, Stephen wrote:
>
> 1)What is the preference in 4x for tasks?  Add a “Project Reference” 
> to things like light, melt, etc. or call out to %WIX%\bin\light.exe?
>
Tasks inherit from WixToolTask to get a bunch of common behavior.

> 2)What solution would you like this task to be in?
>
Whatever the current tasks are in. Solutions aren't used during the 
build; they're just for convenience during development/debugging.

> 3)Should I create a WIP branch of fork it?
>
We definitely need a WIP to cover what's a task and what's a target and 
what things are supported and what aren't.

-- 
sig://boB
http://joyofsetup.com/

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Tunney, S. <Ste...@nu...>]

Hey Bob & Rob,

Ok quick questions regarding this "new" patching task that I'd like to get started on


1)      What is the preference in 4x for tasks?  Add a "Project Reference" to things like light, melt, etc. or call out to %WIX%\bin\light.exe?

2)      What solution would you like this task to be in?

3)       Should I create a WIP branch of fork it?
I'm just excited.  Today is a snow day here in Waterloo and I'm dreaming up things to work on.
Stephen

From: Bob Arnson [mailto:bo...@jo...]
Sent: January-27-15 10:48 PM
To: wix...@li...
Subject: Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

On 27-Jan-15 09:22, Tunney, Stephen wrote:

Bob, exactly.  This MSBuild task would call the Melt, candle, light, torch, and pyro tasks in the background using the supplied values.  This would leverage all of our existing code and provide a simple façade for most users to create "normal" patches.
OK, then I think we're all on the same page for this. Rob, do you concur?


I think it we use that pseudo task definition I laid out in an earlier email the user can create a .proj file that requires a minimal number of inputs (Upgrade MSI path(s), version, bindpaths, etc.) and the task can take care of the rest.
Agreed, though I think that needs more discussion -- maybe a WIP?



--

sig://boB

http://joyofsetup.com/

[WiX-devs] WiX Working Group #55

[Rob M. <ro...@fi...>]

Next WiX Online meeting will be: February 3rd, 2015 @14:30 PST

Agenda items:

*       Triage


.........................................................................................................................................
--> Join Lync Meeting<https://meet.lync.com/firegiant/rob/FWCCRBQB>

Help<http://go.microsoft.com/fwlink/?LinkId=389737>

[!OC([1033])!]
.........................................................................................................................................

Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

[Norbert S. <nor...@on...>]

You are right, validation is a good thing, but I have not enough WiX programming knowledge/skills to program the parameter validation.

Also I have added the missing ReleaseStr to my original pull request and have signed the assignment agreement on January 8.

 

From: Rob Mensching [mailto:ro...@fi...] 
Sent: Tuesday, January 27, 2015 1:06 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

 

If there is no validation, how does someone know what the correct values are? There were no updates to the XSD for documentation purposes. Moreover, since the firewall allows lots of interesting patterns there are a lot more ways to go wrong adding even more value to the validation.

 

I don’t know what you mean by “registry extension”. 

 

Finally, I’d bet dollars to donuts the current firewall code didn’t validate the port range because the person that wrote the code initially didn’t know there was an allowed range.

 

Ultimately, the goal should be to make the code better. If you want to say that validating the values is the wrong thing to do, we should have that debate. If you want to say you don’t want to do the work, then fine. However, let’s not argue that since useful validation was absent before that we should not add the validation now, cool?

 

_______________________________________________________________

FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

 

From: Norbert Schulze [mailto:nor...@on...] 
Sent: Tuesday, January 20, 2015 12:04 PM
To: 'WiX toolset developer mailing list'
Subject: Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

 

Somehow this mail came not through to the mailing list the first time:

 

Any number between 1 and 65535 is valid or any range by these numbers seperated by hyphen or any combination of these seperated by comma.

Is validation necessary? I have only seen this validation where only specific words are allowed.

 

E.g. registry extension doesn't check the parameters.

Also the current firewall port code doesn't check if the number is between 1 and 65535.

 

From: Rob Mensching [mailto:ro...@fi...] 
Sent: Sunday, January 4, 2015 02:50 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

 

Left my one comment. Is there really no validation of the port list required?

 

_______________________________________________________________

FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

 

From: Norbert Schulze [mailto:nor...@on...] 
Sent: Thursday, December 11, 2014 11:42 AM
To: 'WiX toolset developer mailing list'
Subject: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

 

Is there any chance that my pull request will be included in wix3 and wix4 in the near future?

 

 <https://github.com/wixtoolset/wix3/pull/132> https://github.com/wixtoolset/wix3/pull/132

 

Regards, Norbert

Re: [WiX-devs] Coding Standards

[Tunney, S. <Ste...@nu...>]

I'd love to be able to just hit CTRL+K, CTRL+D (format document) and be done with it.

-----Original Message-----
From: Phill Hogland [mailto:pho...@ri...] 
Sent: January-30-15 12:00 PM
To: wix...@li...
Subject: Re: [WiX-devs] Coding Standards

I have been planning to investigate using WixCop tool for same reason, but haven't tried that yet.



--
View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/Coding-Standards-tp7599088p7599094.html
Sent from the wix-devs mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
WiX-devs mailing list
WiX...@li...
https://lists.sourceforge.net/lists/listinfo/wix-devs

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Tunney, S. <Ste...@nu...>]

Checked in changes based on feedback.

https://github.com/wixtoolset/wix3/pull/192

Thanks for the feedback, Bob.  It is appreciated.

Stephen Tunney
Nuance Communications, Inc.
Solutions Architect, Imaging Division
Waterloo, Ontario, Canada
ste...@nu...<mailto:ste...@nu...>
519-880-7463      Office
NUANCE.COM
The experience speaks for itself (tm)

From: Bob Arnson [mailto:bo...@jo...]
Sent: January-29-15 10:57 PM
To: wix...@li...
Subject: Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

Don't forget your wix3 pull request. :)
On 27-Jan-15 22:53, Stephen Tunney wrote:

Let me know.  I will fork wix4 and get a move on it.

On Tue, 27 Jan 2015 22:49 Bob Arnson <bo...@jo...<mailto:bo...@jo...>> wrote:
On 27-Jan-15 09:22, Tunney, Stephen wrote:

Bob, exactly.  This MSBuild task would call the Melt, candle, light, torch, and pyro tasks in the background using the supplied values.  This would leverage all of our existing code and provide a simple façade for most users to create "normal" patches.
OK, then I think we're all on the same page for this. Rob, do you concur?



I think it we use that pseudo task definition I laid out in an earlier email the user can create a .proj file that requires a minimal number of inputs (Upgrade MSI path(s), version, bindpaths, etc.) and the task can take care of the rest.
Agreed, though I think that needs more discussion -- maybe a WIP?




--

sig://boB

http://joyofsetup.com/
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/_______________________________________________
WiX-devs mailing list
WiX...@li...<mailto:WiX...@li...>
https://lists.sourceforge.net/lists/listinfo/wix-devs




------------------------------------------------------------------------------

Dive into the World of Parallel Programming. The Go Parallel Website,

sponsored by Intel and developed in partnership with Slashdot Media, is your

hub for all things parallel software development, from weekly thought

leadership blogs to news, videos, case studies, tutorials and more. Take a

look and join the conversation now. http://goparallel.sourceforge.net/




_______________________________________________

WiX-devs mailing list

WiX...@li...<mailto:WiX...@li...>

https://lists.sourceforge.net/lists/listinfo/wix-devs



--

sig://boB

http://joyofsetup.com/

Re: [WiX-devs] Coding Standards

[Tunney, S. <Ste...@nu...>]

And yes, I've read the web page :) http://wixtoolset.org/development/code-style/


Stephen Tunney
Nuance Communications, Inc.
Solutions Architect, Imaging Division
Waterloo, Ontario, Canada
ste...@nu...<mailto:ste...@nu...>
519-880-7463      Office
NUANCE.COM
The experience speaks for itself (tm)

From: Tunney, Stephen [mailto:Ste...@nu...]
Sent: January-30-15 10:18 AM
To: wix...@li...
Subject: [WiX-devs] Coding Standards

Hey guys,

I'm all for code style consistency.  Do you guys have a tidy-up macro or a code formatting configuration for Visual Studio (2012+) that I can incorporate so that you guys can worry less about whitespace issues in pull requests?

I seem to make this mistake often with your code base.  Maybe I'm the only one? :(

Stephen Tunney
Nuance Communications, Inc.
Solutions Architect, Imaging Division
Waterloo, Ontario, Canada
ste...@nu...<mailto:ste...@nu...>
519-880-7463      Office
NUANCE.COM
The experience speaks for itself (tm)

[WiX-devs] Coding Standards

[Tunney, S. <Ste...@nu...>]

Hey guys,

I'm all for code style consistency.  Do you guys have a tidy-up macro or a code formatting configuration for Visual Studio (2012+) that I can incorporate so that you guys can worry less about whitespace issues in pull requests?

I seem to make this mistake often with your code base.  Maybe I'm the only one? :(

Stephen Tunney
Nuance Communications, Inc.
Solutions Architect, Imaging Division
Waterloo, Ontario, Canada
ste...@nu...<mailto:ste...@nu...>
519-880-7463      Office
NUANCE.COM
The experience speaks for itself (tm)

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Tunney, S. <Ste...@nu...>]

I will update based on your comments this morning :)

Stephen Tunney
Nuance Communications, Inc.
Solutions Architect, Imaging Division
Waterloo, Ontario, Canada
ste...@nu...<mailto:ste...@nu...>
519-880-7463      Office
NUANCE.COM
The experience speaks for itself (tm)

From: Bob Arnson [mailto:bo...@jo...]
Sent: January-29-15 10:57 PM
To: wix...@li...
Subject: Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

Don't forget your wix3 pull request. :)
On 27-Jan-15 22:53, Stephen Tunney wrote:

Let me know.  I will fork wix4 and get a move on it.

On Tue, 27 Jan 2015 22:49 Bob Arnson <bo...@jo...<mailto:bo...@jo...>> wrote:
On 27-Jan-15 09:22, Tunney, Stephen wrote:

Bob, exactly.  This MSBuild task would call the Melt, candle, light, torch, and pyro tasks in the background using the supplied values.  This would leverage all of our existing code and provide a simple façade for most users to create "normal" patches.
OK, then I think we're all on the same page for this. Rob, do you concur?



I think it we use that pseudo task definition I laid out in an earlier email the user can create a .proj file that requires a minimal number of inputs (Upgrade MSI path(s), version, bindpaths, etc.) and the task can take care of the rest.
Agreed, though I think that needs more discussion -- maybe a WIP?




--

sig://boB

http://joyofsetup.com/
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/_______________________________________________
WiX-devs mailing list
WiX...@li...<mailto:WiX...@li...>
https://lists.sourceforge.net/lists/listinfo/wix-devs




------------------------------------------------------------------------------

Dive into the World of Parallel Programming. The Go Parallel Website,

sponsored by Intel and developed in partnership with Slashdot Media, is your

hub for all things parallel software development, from weekly thought

leadership blogs to news, videos, case studies, tutorials and more. Take a

look and join the conversation now. http://goparallel.sourceforge.net/




_______________________________________________

WiX-devs mailing list

WiX...@li...<mailto:WiX...@li...>

https://lists.sourceforge.net/lists/listinfo/wix-devs



--

sig://boB

http://joyofsetup.com/

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Bob A. <bo...@jo...>]

Don't forget your wix3 pull request. :)

On 27-Jan-15 22:53, Stephen Tunney wrote:
>
> Let me know.  I will fork wix4 and get a move on it.
>
>
> On Tue, 27 Jan 2015 22:49 Bob Arnson <bo...@jo... 
> <mailto:bo...@jo...>> wrote:
>
>     On 27-Jan-15 09:22, Tunney, Stephen wrote:
>>
>>     Bob, exactly.  This MSBuild task would call the Melt, candle,
>>     light, torch, and pyro tasks in the background using the supplied
>>     values.  This would leverage all of our existing code and provide
>>     a simple façade for most users to create “normal” patches.
>>
>     OK, then I think we're all on the same page for this. Rob, do you
>     concur?
>
>
>>     I think it we use that pseudo task definition I laid out in an
>>     earlier email the user can create a .proj file that requires a
>>     minimal number of inputs (Upgrade MSI path(s), version,
>>     bindpaths, etc.) and the task can take care of the rest.
>>
>     Agreed, though I think that needs more discussion -- maybe a WIP?
>
>
>     -- 
>     sig://boB
>     http://joyofsetup.com/
>
>     ------------------------------------------------------------------------------
>     Dive into the World of Parallel Programming. The Go Parallel Website,
>     sponsored by Intel and developed in partnership with Slashdot
>     Media, is your
>     hub for all things parallel software development, from weekly thought
>     leadership blogs to news, videos, case studies, tutorials and
>     more. Take a
>     look and join the conversation now.
>     http://goparallel.sourceforge.net/_______________________________________________
>     WiX-devs mailing list
>     WiX...@li... <mailto:WiX...@li...>
>     https://lists.sourceforge.net/lists/listinfo/wix-devs
>
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming. The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net/
>
>
> _______________________________________________
> WiX-devs mailing list
> WiX...@li...
> https://lists.sourceforge.net/lists/listinfo/wix-devs

-- 
sig://boB
http://joyofsetup.com/

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Stephen T. <ste...@gm...>]

Let me know.  I will fork wix4 and get a move on it.

On Tue, 27 Jan 2015 22:49 Bob Arnson <bo...@jo...> wrote:

> On 27-Jan-15 09:22, Tunney, Stephen wrote:
>
>  Bob, exactly.  This MSBuild task would call the Melt, candle, light,
> torch, and pyro tasks in the background using the supplied values.  This
> would leverage all of our existing code and provide a simple façade for
> most users to create “normal” patches.
>
> OK, then I think we're all on the same page for this. Rob, do you concur?
>
>
>   I think it we use that pseudo task definition I laid out in an earlier
> email the user can create a .proj file that requires a minimal number of
> inputs (Upgrade MSI path(s), version, bindpaths, etc.) and the task can
> take care of the rest.
>
> Agreed, though I think that needs more discussion -- maybe a WIP?
>
>
> --
> sig://boBhttp://joyofsetup.com/
>
>  ------------------------------------------------------------
> ------------------
> Dive into the World of Parallel Programming. The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is
> your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> WiX-devs mailing list
> WiX...@li...
> https://lists.sourceforge.net/lists/listinfo/wix-devs
>

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Bob A. <bo...@jo...>]

On 27-Jan-15 09:22, Tunney, Stephen wrote:
>
> Bob, exactly.  This MSBuild task would call the Melt, candle, light, 
> torch, and pyro tasks in the background using the supplied values.  
> This would leverage all of our existing code and provide a simple 
> façade for most users to create “normal” patches.
>
OK, then I think we're all on the same page for this. Rob, do you concur?

> I think it we use that pseudo task definition I laid out in an earlier 
> email the user can create a .proj file that requires a minimal number 
> of inputs (Upgrade MSI path(s), version, bindpaths, etc.) and the task 
> can take care of the rest.
>
Agreed, though I think that needs more discussion -- maybe a WIP?

-- 
sig://boB
http://joyofsetup.com/

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Stephen T. <ste...@gm...>]

Oh, and I think my email to the dev list with that XML in it is currently
awaiting approval. :)


On Tue Jan 27 2015 at 09:24:44 Tunney, Stephen <Ste...@nu...>
wrote:

>  Bob, exactly.  This MSBuild task would call the Melt, candle, light,
> torch, and pyro tasks in the background using the supplied values.  This
> would leverage all of our existing code and provide a simple façade for
> most users to create “normal” patches.
>
> I think it we use that pseudo task definition I laid out in an earlier
> email the user can create a .proj file that requires a minimal number of
> inputs (Upgrade MSI path(s), version, bindpaths, etc.) and the task can
> take care of the rest.
>
>
>
> *From:* Bob Arnson [mailto:bo...@jo...]
> *Sent:* January-26-15 9:21 PM
>
>
> *To:* wix...@li...
> *Subject:* Re: [WiX-devs] Updating Melt to extract files from the Binary
> table for patching
>
>
>
> On 22-Jan-15 13:55, Tunney, Stephen wrote:
>
>  You’re suggesting that we remove the melt and torch steps and have pyro
> encompass **everything** that patch building requires?  Or is this the
> Pyro MSBuild Task that you speak of?
>
> The latter. We need the building-block tools (torch, pyro) but can build
> tasks and targets on top of them.
>
>
>  If we move to a MSBuild style the only questions that really need to be
> asked are:
>
> RTM MSI paths
>
> Upgrade MSI paths
>
> Patch Families to create
>
> Version
>
> Type
>
> I'm not talking about having MSBuild replace patch authoring. There's too
> much there to do it all in the project. That could be an option for a
> high-level, limited-scope kind of patching (i.e., no filtering). Before
> that, we need tasks and targets that drive "normal" patching.
>
>
>  --
>
> sig://boB
>
> http://joyofsetup.com/
>
>  ------------------------------------------------------------
> ------------------
> Dive into the World of Parallel Programming. The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is
> your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> WiX-devs mailing list
> WiX...@li...
> https://lists.sourceforge.net/lists/listinfo/wix-devs
>

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Tunney, S. <Ste...@nu...>]

Bob, exactly.  This MSBuild task would call the Melt, candle, light, torch, and pyro tasks in the background using the supplied values.  This would leverage all of our existing code and provide a simple façade for most users to create "normal" patches.
I think it we use that pseudo task definition I laid out in an earlier email the user can create a .proj file that requires a minimal number of inputs (Upgrade MSI path(s), version, bindpaths, etc.) and the task can take care of the rest.

From: Bob Arnson [mailto:bo...@jo...]
Sent: January-26-15 9:21 PM
To: wix...@li...
Subject: Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

On 22-Jan-15 13:55, Tunney, Stephen wrote:

You're suggesting that we remove the melt and torch steps and have pyro encompass *everything* that patch building requires?  Or is this the Pyro MSBuild Task that you speak of?
The latter. We need the building-block tools (torch, pyro) but can build tasks and targets on top of them.


If we move to a MSBuild style the only questions that really need to be asked are:
RTM MSI paths
Upgrade MSI paths
Patch Families to create
Version
Type
I'm not talking about having MSBuild replace patch authoring. There's too much there to do it all in the project. That could be an option for a high-level, limited-scope kind of patching (i.e., no filtering). Before that, we need tasks and targets that drive "normal" patching.



--

sig://boB

http://joyofsetup.com/

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Bob A. <bo...@jo...>]

On 22-Jan-15 13:55, Tunney, Stephen wrote:
> You’re suggesting that we remove the melt and torch steps and have 
> pyro encompass **everything** that patch building requires?  Or is 
> this the Pyro MSBuild Task that you speak of?
The latter. We need the building-block tools (torch, pyro) but can build 
tasks and targets on top of them.

> If we move to a MSBuild style the only questions that really need to 
> be asked are:
>
> RTM MSI paths
>
> Upgrade MSI paths
>
> Patch Families to create
>
> Version
>
> Type
>
I'm not talking about having MSBuild replace patch authoring. There's 
too much there to do it all in the project. That could be an option for 
a high-level, limited-scope kind of patching (i.e., no filtering). 
Before that, we need tasks and targets that drive "normal" patching.

-- 
sig://boB
http://joyofsetup.com/

Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

[Bob A. <bo...@jo...>]

On 26-Jan-15 19:06, Rob Mensching wrote:
> Finally, I’d bet dollars to donuts the current firewall code didn’t 
> validate the port range because the person that wrote the code 
> initially didn’t know there was an allowed range.
I'll take that bet. The reason there's little validation is that 
originally, port was a single integer -- but it could be a formatted 
string. The firewall API gives feedback on each attribute of the 
firewall rule.

There's also the question of which rules to validate against (XP's or 
Vista's).

Dollars, please.

-- 
sig://boB
http://joyofsetup.com/

Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

[Rob M. <ro...@fi...>]

If there is no validation, how does someone know what the correct values are? There were no updates to the XSD for documentation purposes. Moreover, since the firewall allows lots of interesting patterns there are a lot more ways to go wrong adding even more value to the validation.

I don’t know what you mean by “registry extension”.

Finally, I’d bet dollars to donuts the current firewall code didn’t validate the port range because the person that wrote the code initially didn’t know there was an allowed range.

Ultimately, the goal should be to make the code better. If you want to say that validating the values is the wrong thing to do, we should have that debate. If you want to say you don’t want to do the work, then fine. However, let’s not argue that since useful validation was absent before that we should not add the validation now, cool?

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Norbert Schulze [mailto:nor...@on...]
Sent: Tuesday, January 20, 2015 12:04 PM
To: 'WiX toolset developer mailing list'
Subject: Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

Somehow this mail came not through to the mailing list the first time:

Any number between 1 and 65535 is valid or any range by these numbers seperated by hyphen or any combination of these seperated by comma.
Is validation necessary? I have only seen this validation where only specific words are allowed.

E.g. registry extension doesn't check the parameters.
Also the current firewall port code doesn't check if the number is between 1 and 65535.

From: Rob Mensching [mailto:ro...@fi...]
Sent: Sunday, January 4, 2015 02:50 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

Left my one comment. Is there really no validation of the port list required?

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Norbert Schulze [mailto:nor...@on...]
Sent: Thursday, December 11, 2014 11:42 AM
To: 'WiX toolset developer mailing list'
Subject: [WiX-devs] Issue #4206 - Firewall port list or range not possible #132

Is there any chance that my pull request will be included in wix3 and wix4 in the near future?

https://github.com/wixtoolset/wix3/pull/132

Regards, Norbert

[WiX-devs] WiX Working Group #54

[Rob M. <ro...@fi...>]

Next WiX Online meeting will be: January 27nd, 2015 @14:30 PST

Agenda items:

*       Triage
*       Review WIP 4632 & 4658


.........................................................................................................................................
--> Join Lync Meeting<https://meet.lync.com/firegiant/rob/S1K15HHN>

Help<http://go.microsoft.com/fwlink/?LinkId=389737>

[!OC([1033])!]
.........................................................................................................................................

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Tunney, S. <Ste...@nu...>]

From: Bob Arnson [mailto:bo...@jo...]
Sent: January-21-15 5:27 PM
To: wix...@li...
Subject: Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

On 21-Jan-15 16:29, Rob Mensching wrote:

Isn't this what we're discussing? Different ways to solve the patching problem? I totally agree we haven't hit consensus.
Right -- talking is how we get there. In person, this would be a shorter conversation with people swapping positions between Visual Studio on a laptop and multiple colors of pen at a whiteboard. :)
I'm all for the talking :)  Sometimes I seem impatient...  sometimes I *am* impatient.  I apologize for coming off as such.

We've worked our way to a big question, the "higher level model" in Bob's words, of how to make patching really work, instead of the disconnected set of tools we use today. I suggested we maybe should consider the MSBuild targets to get there and I think Bob agreed that's a good place to start...
For sure. Mostly it's a question of whether we keep using single-purpose tools wrapped in targets or we start moving more logic into tasks/targets (or other higher-level tools that are then wrapped in targets).
Now that we are talking about tasks/targets I'm getting a little more excited.  I'd really like to see something in my .wixproj for patching that defines the RTM paths, the families, versioning, types, and Upgrade MSI paths.  Everything else could be take from there.  To be honest I think we could even automatically generate a wxi file that has the extracted TargetProductCode and Media elements, this file would also drive the creation of the "-t" arguments for pyro.

Sorry if the process takes a little bit to get there. Patching is both one of the hardest parts of the Windows Installer and the least developed in the WiX toolset. I expect we still have quite a bit of ground to cover to get to an answer.  Do you agree?
As usual, we have the right tools to support everything that MSI supports, even if it's not the simplest to execute on.
Let's continue on with the assumption that an MSBuild task is the way to go to aggregate this functionality.  I think we have a winner here too!

Right now we're missing information. Can we easily adapt to using .msi+.wixpdb pairs inside pyro? Peter added the admin-image stuff so that points to yes but for some reason I'm not feeling confident.
You're suggesting that we remove the melt and torch steps and have pyro encompass *everything* that patch building requires?  Or is this the Pyro MSBuild Task that you speak of?

If we move to a MSBuild style the only questions that really need to be asked are:
RTM MSI paths
Upgrade MSI paths
Patch Families to create
Version
Type

If these were the questions answered everything else can either be auto-generated or inspected from the contents of the values given.

To be honest I already have this set up in NAnt as a set of targets.  Transitioning to MSBuild as a task/target wouldn't take too much effort.



--

sig://boB

http://joyofsetup.com/

Re: [WiX-devs] 4632 - Use ETW for logging and additional tracing

[Rob M. <ro...@fi...>]

Agreed except there would need to be something really compelling in .NET v4.5 for us to move there. It seems .NET v4.0 serves us just fine.

_______________________________________________________________
 FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

-----Original Message-----
From: Bob Arnson [mailto:bo...@jo...] 
Sent: Wednesday, January 21, 2015 2:43 PM
To: wix...@li...
Subject: Re: [WiX-devs] 4632 - Use ETW for logging and additional tracing

On 20-Jan-15 23:14, Sean Hall wrote:
> Are we planning on dropping support for XP in 4.x? Does that mean we 
> should bump up to .NET 4.5?
Runtime, I agree with Rob: It'll be a couple of years before XP drops to nuisance levels. Build time, I think it'd be fine to assume Windows >=7 and .NET 4.>=5.

--
sig://boB
http://joyofsetup.com/


------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
WiX-devs mailing list
WiX...@li...
https://lists.sourceforge.net/lists/listinfo/wix-devs

Re: [WiX-devs] Agenda items for next meeting

[Rob M. <ro...@fi...>]

Got it thanks.

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Sean Hall [mailto:r.s...@gm...]
Sent: Thursday, January 22, 2015 10:43 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] Agenda items for next meeting

Can we discuss WIP 4632 about ETW and WIP 4658 about button functionality in thmutil at the next meeting?

Thanks,
Sean

[WiX-devs] Agenda items for next meeting

[Sean H. <r.s...@gm...>]

Can we discuss WIP 4632 about ETW and WIP 4658 about button functionality
in thmutil at the next meeting?

Thanks,
Sean

Re: [WiX-devs] 4632 - Use ETW for logging and additional tracing

[Bob A. <bo...@jo...>]

On 20-Jan-15 23:14, Sean Hall wrote:
> Are we planning on dropping support for XP in 4.x? Does that mean we 
> should bump up to .NET 4.5?
Runtime, I agree with Rob: It'll be a couple of years before XP drops to 
nuisance levels. Build time, I think it'd be fine to assume Windows >=7 
and .NET 4.>=5.

-- 
sig://boB
http://joyofsetup.com/

Re: [WiX-devs] Updating Melt to extract files from the Binary table for patching

[Bob A. <bo...@jo...>]

On 21-Jan-15 16:29, Rob Mensching wrote:
>
> Isn’t this what we’re discussing? Different ways to solve the patching 
> problem? I totally agree we haven’t hit consensus.
>
Right -- talking is how we get there. In person, this would be a shorter 
conversation with people swapping positions between Visual Studio on a 
laptop and multiple colors of pen at a whiteboard. :)

> We’ve worked our way to a big question, the “higher level model” in 
> Bob’s words, of how to make patching really work, instead of the 
> disconnected set of tools we use today. I suggested we maybe should 
> consider the MSBuild targets to get there and I think Bob agreed 
> that’s a good place to start…
For sure. Mostly it's a question of whether we keep using single-purpose 
tools wrapped in targets or we start moving more logic into 
tasks/targets (or other higher-level tools that are then wrapped in 
targets).

> Sorry if the process takes a little bit to get there. Patching is both 
> one of the hardest parts of the Windows Installer and the least 
> developed in the WiX toolset. I expect we still have quite a bit of 
> ground to cover to get to an answer.  Do you agree?
>
As usual, we have the right tools to support everything that MSI 
supports, even if it's not the simplest to execute on.

Right now we're missing information. Can we easily adapt to using 
.msi+.wixpdb pairs inside pyro? Peter added the admin-image stuff so 
that points to yes but for some reason I'm not feeling confident.

-- 
sig://boB
http://joyofsetup.com/

Re: [WiX-devs] WiX Online Meeting time in 2015?

[Rob M. <ro...@fi...>]

Sorry for the late notice for the meeting tomorrow, but given feedback, we’ll try just moving what was the standard meeting last year back an hour. Hopefully, you can all attend.

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Sean Hall [mailto:r.s...@gm...]
Sent: Monday, January 19, 2015 8:06 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] WiX Online Meeting time in 2015?

10:00 AM Pacific or 3:00 PM Pacific works for me

On Mon, Jan 19, 2015 at 3:09 PM, Rob Mensching <ro...@fi...<mailto:ro...@fi...>> wrote:
An hour earlier won’t help much. It’d have to be probably 3 hours earlier (6:00 AM PST) to have any hope of not being interrupted by life here. <smile/>

However, it seems like many are interested in taking it back an hour (10:00 AM PST). That’s the time we had two weeks ago.

Just for discussion, what about Tuesday 3:00 PM PST?  That’s a very different time slot and probably hits east coasters at a poor time. Thoughts?

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Hoover, Jacob [mailto:Jac...@gr...<mailto:Jac...@gr...>]
Sent: Monday, January 19, 2015 7:44 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] WiX Online Meeting time in 2015?

An hour earlier or later would be fine by me (if that helps at all).


From: Rob Mensching [mailto:ro...@fi...]
Sent: Sunday, January 18, 2015 1:53 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] WiX Online Meeting time in 2015?

Greetings,

Last year our weekly meeting was regularly scheduled at 9:00 AM PST on Thursdays. Due to changes in life, 9:00 AM PST is turning out to be very challenging for me to attend regularly. Thus I’d like to move the meeting time to another timeslot.

Of course, no time slot can be perfect but we’d like to accommodate as many people as possible. So, does anyone have suggestions or anti-suggestions (time that will never work)?

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/


------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
WiX-devs mailing list
WiX...@li...<mailto:WiX...@li...>
https://lists.sourceforge.net/lists/listinfo/wix-devs