[WiX-devs] [ wix-Bugs-935270 ] candle: wxo contains wrong line numbers for CustomTable rows

[SourceForge.net <no...@so...>]

Bugs item #935270, was opened at 2004-04-14 15:35
Message generated for change (Comment added) made by robmen
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=935270&group_id=105970

>Category: candle
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Mattie Casper (rezand)
>Assigned to: Rob Mensching (robmen)
Summary: candle: wxo contains wrong line numbers for CustomTable rows

Initial Comment:
If you look at the wxo columns and rows for 
CustomTable entries, you'll notice the source line is 
incorrect. It seems to be pointing to the top-level 
CustomTable node for that table instead of the row/data 
line in question.

I believe this just results from the lines from 
ParseCustomTableElement:

foreach (XmlNode child in node.ChildNodes)
            {
                SourceLineNumber[] childSourceLineNumbers 
= this.GetSourceLineNumbers(node);


This should probably be: 

                SourceLineNumber[] childSourceLineNumbers 
= this.GetSourceLineNumbers(child);


Additionally, when parsing the rows in that function, it 
probably should be:
                    case "Row":
                        string dataValue = null;
                        int fieldCount = 0;
                        foreach (XmlNode data in 
child.ChildNodes)
                        {
                            SourceLineNumber[] 
dataSourceLineNumbers = this.GetSourceLineNumbers
(data);


Notice the "data" at the end instead.

----------------------------------------------------------------------

>Comment By: Rob Mensching (robmen)
Date: 2004-04-21 16:22

Message:
Logged In: YES 
user_id=991639

Several simple cut and paste mistakes like this were fixed.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=935270&group_id=105970