Re: [WiX-devs] Optional command line arguments WIP updated

[Bob A. <bo...@fi...>]

You're both wrong. :) I wanted to use WixBundleExecutePackageAction instead of On* attributes so each CommandLine instance was just argument and condition. That said, Rob's proposed authoring looks awesome. And I think it's not much more complex than what I was thinking of.

Unless someone objects, I'm going with that (and will update the WIP to match).

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Hoover, Jacob [mailto:Jac...@gr...]
Sent: Friday, 27 March, 2015 14:42
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Optional command line arguments WIP updated

The way I read it was

    <ExePackage RepairCommand="" UninstallCommand="/uninstall">
       <CommandLine OnInstall="yes" OnRepair="yes" Conditon="VarX=1">/foo /bar</CommandLine>
       <CommandLine OnUninstall="yes" Conditon="VarY=9">/notfoo</CommandLine>
    </ExePackage>


From: Rob Mensching [mailto:ro...@fi...]
Sent: Friday, March 27, 2015 1:28 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Optional command line arguments WIP updated

I like this. I could really use a couple examples (sorry, "visualizing" changes is easiest way for me to understand)

So you are suggesting the following:

    <ExePackage RepairCommand="" UnisntallCommand="/uninstall">
       <CommandLine InstallArgument="/foo /bar"  RepairArgument="/foo /bar"  Conditon="VarX=1" />
       <CommandLine UninstallArgument="/notfoo" Conditon="VarY=9" />
    </ExePackage>

That would match our use of InstallCommand, RepairCommand, UninstallCommand and probably avoid the use of the WixBundleExecutePackageAction 90+% of the time.

If so, I *really* like this.

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Bob Arnson [mailto:bo...@fi...]
Sent: Wednesday, March 25, 2015 9:46 AM
To: wix...@li...<mailto:wix...@li...>
Subject: [WiX-devs] Optional command line arguments WIP updated

You can see the diff via pull request at https://github.com/wixtoolset/site/pull/50.

I'm strongly leaning toward the "package action variable." It's simple to implement and basically solves the problem adding this functionality to MsiProperty.

Feedback sought and welcomed.

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/