Re: [WiX-devs] Pull request

[Rob M. <ro...@fi...>]

A single commit? Uhh, that's rarely ideal. It's much better to see logical commits to make it easier to review. Sean had a great example when he did the thmutil updates in v4.

In this case, we've already reviewed this so it's less of an issue. You don't need a new pull request. Just update the branch you sent the pull request from and it should be good.

_______________________________________________________________
FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/

From: Hoover, Jacob [mailto:Jac...@gr...]
Sent: Tuesday, March 24, 2015 11:09 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] Pull request

Rob,
  for https://github.com/wixtoolset/wix4/pull/80.  I have a squashed branch located at https://github.com/jchoover/wix4/tree/SelfUpdateTesting.v2; I could kill the old pull request and submit the new one so it's a single commit.  I think I've addressed all the concerns/feedback that was provided.  I've also merged in all changes from upstream, so it should auto-merge for you.

Thanks,
Jacob