Menu ▾ ▴

#2938 light 3.6 rc0 not recognize std dir root in merge module

v3.6
closed
light (353)
2012-09-15
2012-05-11
No

A merge module that compiles and links successfully in 3.5 RTM fails with LGHT0231 in 3.6 RC0. Minimal test case attached. Foo.txt is an empty plain-text file.

Output, demonstrating that the change in behavior can be isolated to light:

[C:\dev\WixTest]%WIX35%candle Lght0231MsmTest.wxs -o Lght0231MsmTest-35.wixobj
Microsoft (R) Windows Installer Xml Compiler version 3.5.2519.0
Copyright (C) Microsoft Corporation. All rights reserved.

Lght0231MsmTest.wxs

[C:\dev\WixTest]%WIX35%light Lght0231MsmTest-35.wixobj -o Lght0231MsmTest-35.msm

Microsoft (R) Windows Installer Xml Linker version 3.5.2519.0
Copyright (C) Microsoft Corporation. All rights reserved.

[C:\dev\WixTest]%WIX36%candle Lght0231MsmTest.wxs -o Lght0231MsmTest-36.wixobj
Microsoft (R) Windows Installer Xml Compiler version 3.6.2803.0
Copyright (C) Microsoft Corporation. All rights reserved.

Lght0231MsmTest.wxs

[C:\dev\WixTest]%WIX36%light Lght0231MsmTest-36.wixobj -o Lght0231MsmTest-36.msm

Microsoft (R) Windows Installer Xml Linker version 3.6.2803.0
Copyright (C) Microsoft Corporation. All rights reserved.

C:\dev\WixTest\Lght0231MsmTest.wxs(12) : error LGHT0231 : The component 'Foo.txt.0ADB43F9_841C_4AA0_AFCC_48CB90CD013A' has a key file with path 'TARGETDIR\foo\bar\foo.txt'. Since this path is not rooted in one of the standard directories (like ProgramFilesFolder), this component does not fit the criteria for having an automatically generated guid. (This error may also occur if a path contains a likely standard directory such as nesting a directory with name "Common Files" under ProgramFilesFolder.)

[C:\dev\WixTest]%WIX36%light Lght0231MsmTest-35.wixobj -o Lght0231MsmTest-c35-l36.msm
Microsoft (R) Windows Installer Xml Linker version 3.6.2803.0
Copyright (C) Microsoft Corporation. All rights reserved.

C:\dev\WixTest\Lght0231MsmTest.wxs(12) : error LGHT0231 : The component 'Foo.txt.0ADB43F9_841C_4AA0_AFCC_48CB90CD013A' has a key file with path 'TARGETDIR\foo\bar\foo.txt'. Since this path is not rooted in one of the standard directories (like ProgramFilesFolder), this component does not fit the criteria for having an automatically generated guid. (This error may also occur if a path contains a likely standard directory such as nesting a directory with name "Common Files" under ProgramFilesFolder.)

[C:\dev\WixTest]%WIX35%light Lght0231MsmTest-36.wixobj -o Lght0231MsmTest-c36-l35.msm
Microsoft (R) Windows Installer Xml Linker version 3.5.2519.0
Copyright (C) Microsoft Corporation. All rights reserved.

Discussion

  • Michael Turner

    Michael Turner - 2012-05-11

    Minimal test case

     
  • Rob Mensching

    Rob Mensching - 2012-05-11

    TARGETDIR is not a well-known directory. The error message is correct.

     
  • Michael Turner

    Michael Turner - 2012-05-11

    CNDL0205 requires the root of a merge module to be TARGETDIR with Name="SourceDir". Does this mean that auto-generated component GUIDs will no longer be supported in merge modules, except by specifying a Directory@ComponentGuidGenerationSeed?

    I was planning on converting many organization-internal MSMs to Fragments or Wixlibs anyway, so I can make this a prerequisite to 3.6 adoption if necessary.

     
  • Rob Mensching

    Rob Mensching - 2012-05-11

    Auto-generated Component GUIDs were never supported in Merge Modules unless you used Directory@ComponentGuidGenerationSeed. <smile></smile>

    .wixlibs are pretty much fundamentally better than Merge Modules.