Find fix for http://forums.winmerge.org/viewtopic.php?f=6&t=829 attached. Patch is against R2_14.
It would probably be good to get this bug fixed before we release 2.14
This patch seems to be doing a bit more than fixing the bug.
The function PathQuoteSpaces is new, where is it? and what is the function supposed to do?
The function PathMatchSpec is new, where is it? and what is the function supposed to do?
Why did strWinMergePath need to be changed from String to TCHAR?
What's the advantage to using SHRegGetPath as opposed to what we already had?
Please consult MSDN about the functions in question.
Attached is the smallest patch I can come up with to resolve this issue.
It's a one line change to add quotes to the command line.
I'll get this fix added, and then release version 2.14
Committed to R2_14 branch at revision 7594
Committed to trunk at revision 7595
The point of avoiding String in ShellExtension is that String can throw exceptions and ShellExtension does not handle them but lets them go outside to the hosting application. While not fixing the issue in all places, the proposed patch was a first step towards fixing it.
Okay, that is a good point.
We could fix that in trunk, I have no problem with that.
But in the R2_14 branch on the day before a release we should be extremely conservative with the fixes.
Log in to post a comment.