#3023 Shell extension uses unquoted program path

Branch_+_Trunk
closed-accepted
nobody
5
2013-02-03
2013-01-27
No

Discussion

  • Christian List

    Christian List - 2013-01-27

    It would probably be good to get this bug fixed before we release 2.14

    This patch seems to be doing a bit more than fixing the bug.

    The function PathQuoteSpaces is new, where is it? and what is the function supposed to do?
    The function PathMatchSpec is new, where is it? and what is the function supposed to do?
    Why did strWinMergePath need to be changed from String to TCHAR?
    What's the advantage to using SHRegGetPath as opposed to what we already had?

     
  • Christian List

    Christian List - 2013-01-27
    • labels: --> File handling
     
  • Jochen Tucht

    Jochen Tucht - 2013-01-28

    Please consult MSDN about the functions in question.

     
  • Christian List

    Christian List - 2013-02-02

    Attached is the smallest patch I can come up with to resolve this issue.
    It's a one line change to add quotes to the command line.
    I'll get this fix added, and then release version 2.14

     
  • Christian List

    Christian List - 2013-02-02

    Committed to R2_14 branch at revision 7594

     
  • Christian List

    Christian List - 2013-02-02
    • status: open --> open-accepted
     
  • Christian List

    Christian List - 2013-02-02

    Committed to trunk at revision 7595

     
  • Jochen Tucht

    Jochen Tucht - 2013-02-03

    The point of avoiding String in ShellExtension is that String can throw exceptions and ShellExtension does not handle them but lets them go outside to the hosting application. While not fixing the issue in all places, the proposed patch was a first step towards fixing it.

     
  • Christian List

    Christian List - 2013-02-03

    Okay, that is a good point.
    We could fix that in trunk, I have no problem with that.

    But in the R2_14 branch on the day before a release we should be extremely conservative with the fixes.

     
  • Christian List

    Christian List - 2013-02-03
    • Status: open-accepted --> closed-accepted
    • Priority: 3 --> 5
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks