#2994 Crash after deleting text

Branch_+_Trunk
closed-fixed
nobody
GUI (476)
5
2010-11-21
2010-11-15
No

I had a file-comparison open and deleted all text on both sides (Ctrl-A, Del). Then I switched to another application, copied some text and wanted to copy it into one pane. But when switching back to WinMerge it crashed.
(may be related to Bug-ID: 3058807 - Crash on marking text)

The crash happened in the function GetLineFlags() when OnDraw tried to access lines that do not exist anymore.

Discussion

  • Lars Wittenburg

    Lars Wittenburg - 2010-11-15

    Checking line count in CMergeEditView::GetLineColors2

     
  • Kimmo Varis

    Kimmo Varis - 2010-11-20

    Thanks for the patch! This fixes the crash (and can be applied as such) but I think the real problem is why we try to get line colors for non-existing line...

     
  • Tim Gerundt

    Tim Gerundt - 2010-11-21

    Committed to SVN:

    * In Revision 7439 (Trunk)
    * In Revision 7440 (Branch R2_14)

    Thank you very much for the patch!

     
  • Tim Gerundt

    Tim Gerundt - 2010-11-21
    • milestone: --> Branch_+_Trunk
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks