#2917 Quickcompare and EOL

Branch_+_Trunk
closed-accepted
nobody
5
2010-11-16
2010-01-09
Matthias
No

this patch solve bugreport
ID 2210403 Quick contents compare does not ignore EOL differences

seam this code must be refractored.

Discussion

  • Matthias

    Matthias - 2010-01-09

    bytecompare corrected

     
  • Kimmo Varis

    Kimmo Varis - 2010-01-11

    Yes! This seems to be fixing that very annoying bug! Will apply the patch in couple of minutes...

     
  • Kimmo Varis

    Kimmo Varis - 2010-01-11
    • status: open --> closed-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2010-01-11

    Committed to SVN trunk:
    Completed: At revision: 7090

     
  • Kimmo Varis

    Kimmo Varis - 2010-07-19

    Reopening. I received a message from user telling this patch causes a infinite loop when comparing binary files. The user has confirmed that by reverting this patch.

    Thinking about this patch in context I think it is indeed a buggy - the if matches also if BOTH files are at end. Then we don't want to get more data but now the code tries to do that. So the fix may be a small change to the if so that it is exclusive or - only other file must be at the end, but not both. Or did I miss something?

     
  • Kimmo Varis

    Kimmo Varis - 2010-07-19
    • status: closed-accepted --> open-accepted
     
  • Matthias

    Matthias - 2010-07-19

    bytecompare

     
  • Matthias

    Matthias - 2010-07-19

    yes, there was a endless chance.
    Can you test it.. I could not download your sample files, error-free.

     
  • Kimmo Varis

    Kimmo Varis - 2010-08-05
    • status: open-accepted --> closed-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2010-08-05

    I\ve no files to reproduce the hang. I sent message to person telling about the problem but he hasn't responded.

    The patch looks good so I'll just apply it.

    Committed the new patch to SVN trunk:
    Completed: At revision: 7228

     
  • Matthias

    Matthias - 2010-08-05

    files are at ID 2210403 Quick contents compare does not ignore EOL differences
    sorry I cannot download correctly. I know I had that problem alst time also.

     
  • Tim Gerundt

    Tim Gerundt - 2010-11-16
    • milestone: 438013 --> Branch_+_Trunk
     
  • Tim Gerundt

    Tim Gerundt - 2010-11-16

    Backported to branch R2_14 (In Revision 7427)...

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks