Menu

#2895 last char is shown double

Trunk
closed-out-of-date
nobody
GUI (476)
5
2009-12-21
2009-10-11
Matthias
No

in case we have a diff followed by an insert, the last char in that line is shown double.
this patch solves that.

Discussion

  • Matthias

    Matthias - 2009-10-11

    last char shown only once

     
  • Kimmo Varis

    Kimmo Varis - 2009-10-11

    What is the last change of MergeEditView.cpp for? How is it related to showing last char of the line?

    Please attach files for reproducing the bug.

     
  • Kimmo Varis

    Kimmo Varis - 2009-10-11
    • milestone: 438015 --> Trunk
     
  • Matthias

    Matthias - 2009-10-12

    sorry I'm outside again, I cannot upload anything. Set char level on.
    ' I go hom' ' I go home now'
    You will see 'homm' left ('m' is double).

    I can also protect this in stringdiffs when I' m back. Makes a little bit more sence.

     
  • Kimmo Varis

    Kimmo Varis - 2009-10-18

    You did not answer my question.

     
  • Matthias

    Matthias - 2009-10-19

    the pointer to last char is same, so it's shown double.

    I'will try to solve that in stringdiffs, that's faster. As it's only done once.
    will take a week more to do.

     
  • Kimmo Varis

    Kimmo Varis - 2009-10-24

    So you don't want to answer my simple question. Not the way to get patches in.

     
  • Matthias

    Matthias - 2009-10-25

    sorry I'm still outside. I have no system with me.
    So from my mind. The editor is useing the diffs to display the single chars.
    On last insert, the position is same in case we have also a diff just before.
    So the editor is moving the cursor to the last char twice.
    Wait till tuesday, I will give the change in stringdiffs, as I allready told that will be faster.

     
  • Matthias

    Matthias - 2009-10-30

    I'd solved tha part in patch ID: 2876480 stringdiff more details
    there it's faster as it is done onmly once.

    do be closed

     
  • Kimmo Varis

    Kimmo Varis - 2009-12-21
    • status: open --> closed-out-of-date
     
  • Kimmo Varis

    Kimmo Varis - 2009-12-21

    Did I understand correctly this is now outdated? Closing as such.

     

Log in to post a comment.