#275 CMergeDoc handles diffoptions

closed-rejected
nobody
None
5
2003-08-28
2003-08-25
Kimmo Varis
No

Next step with (diff)options. I'm doing this few steps
to make patch simpler and testing easier.

This patch:
* Adds CMergeDoc::ReadSettings() to mergedocs read
their settings
* CMergeDoc::Rescan() and CMergeDoc::Showlinediff() now
use CMergeDoc::m_diffWrapper settings, not CMainFrame
settings.
* When CMainFrame changes options,
CMergeDoc::ReadSettings() is called to read saved
settings from registry()
* CDiffWrapper loads diffsettings from registry in
constructor.

Also couple of diffoptions I missed earlier are added
to DiffWrapper.

My plan is to add ReadSettings() and SaveSettings() to
CMergeDoc and CDirDoc. Then docs can read and save
their settings independently from CMainFrame.

CMainFrame still knows options user can change using
options dialog. But instead docs using CMainFrame
members, CMainFrame saves settings to registry and
tells docs to re-read them.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2003-08-28
    • status: open --> closed-rejected
     
  • Kimmo Varis

    Kimmo Varis - 2003-08-28

    Logged In: YES
    user_id=631874

    Rejecting and closing. I have better solution and will
    submit new patch later today. My current patch moves all
    diffutils options handling to CDiffWrapper class.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks