This code modification results in a user interface change, with a new checkbox added to the File/Directory Open dialog.
It implements the feature as described in the initial request.
Thanks for the patch!
However, I'm not sure implementing this is a good idea:
- it adds more controls to open-dialog. Which I've been denying as the dialog is already too busy. And it is the dialog people most often use and use first when they start WinMerge.
- it's general usefulness is questionable. Is it really a common case to have synchronized MRU lists?
And as I already wrote to the feature request, perhaps using project files for paths compared often would be a better solution.
I think it's a helpful feature. As the person that proposed it noted, it's something you can find in other applications. People can use project files to accomplish the same thing, I guess, but this choice involves lower cognitive overhead (no project/create or open step -- no need to remember a new association between project name and file/dir pair).
The only problem I see is documenting it correctly (best choice of feature "name"), and translation. Also, I noticed that the Open dialog is designed to be resizable. I didn't integrate the new checkbox with layout management.
My real problem is adding more controls to Open-dialog. This would be one control. But then if I allow this, I have difficulties to not accept few more (equally important) controls for e.g. switching paths. Imagine Open-dialog with 3-4 more buttons and then try to document it for new users. This easily gets out of hand, as the requests for more controls (like this one) are basically good and needed.
So my solution has been to not add any controls - no matter how needed the change would be. And I've said in many requests that we need some redesign for Open-dialog first.
One idea I've thought is adding new tab or make dialog expandable vertically so that only path selection controls are visible in main tab/without expanding the dialog.
Lowering the priority. It is good to have this patch around in tracker even though I don't want this as a solution. (And just for note, after this patch was submitted couple of other controls have been suggested to be added to Open-dialog since it (always) is just one control... Sometimes this is not funny...)
This might come in handy for someone.
But since we are not including it in the WinMerge source, I've changed the status to open-rejected
Log in to post a comment.
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.