Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#2644 Unlimited undo

Branch_+_Trunk
closed-accepted
Usability (141)
5
2008-08-03
2008-07-31
Kimmo Varis
No

Fixes bug item:
#2032925 Undo buffer ASSERTs when copying lots of diffs
http://winmerge.org/bug/2032925

Currently there is a hard limit of 1024 undo records in the editor code. And as the referred bug demonstrates the limiting code is also buggy.

There is no technical reason nowadays to limit undo records. Those records of course take some memory. With referred bug and debug build it was like 8 megs. And there are over 2000 diffs in that file. We could use ten times more memory without any noticeable effect. And that is a lot of undo buffer.

In addition to the referenced bug, there is usability problem of dropping undo records from memory. It may cause unreversible data loss for user to do only a partial undo after doing copy all for diffs in file.

So this patch removes the undo limit and the only limit will be amount of memory available.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2008-07-31

    Original and altered files

     
  • Kimmo Varis

    Kimmo Varis - 2008-08-01

    Logged In: YES
    user_id=631874
    Originator: YES

    Committed to SVN trunk:
    Completed: At revision: 5712

     
  • Kimmo Varis

    Kimmo Varis - 2008-08-01
    • assigned_to: nobody --> kimmov
    • status: open --> open-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2008-08-01

    Logged In: YES
    user_id=631874
    Originator: YES

    Missed one file in previous commit, so committed to SVN trunk:
    Completed: At revision: 5713

     
  • Kimmo Varis

    Kimmo Varis - 2008-08-03

    Logged In: YES
    user_id=631874
    Originator: YES

    Committed to 2.10 branch:
    Completed: At revision: 5727

     
  • Kimmo Varis

    Kimmo Varis - 2008-08-03
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.