Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#2625 Add dialog listing available plugins

Branch_+_Trunk
closed-accepted
Plugins (55)
5
2008-07-21
2008-07-18
Kimmo Varis
No

This patch builds on work done in patch:
#2013845 Add option to enable plugins (disabled by default)
http://winmerge.org/patch/2013845

This patch adds a new dialog which lists all available plugins. I decided to add this kind of dialog since I realized there is no way for user to know which plugins there are installed. Another reason was I wanted better place for plugins enabling/disabling option. Options/General added in earlier patch is not a good place for such option and is easy to miss.

The dialog shows name, type and description for each plugin.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2008-07-18

    Original and altered files

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-18

    Logged In: YES
    user_id=631874
    Originator: YES

    File Added: PluginsList.png

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-18

    Screenshot of the dialog

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-19

    Logged In: YES
    user_id=631874
    Originator: YES

    Forgot to add two new files (the dialog implementation!) files to the patch. Attaching new patch with those missing files included.
    File Added: PluginsListDialog_2.7z

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-19

    Logged In: YES
    user_id=631874
    Originator: YES

    Committed to SVN trunk:
    Completed: At revision: 5639

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-19
    • assigned_to: nobody --> kimmov
    • status: open --> open-accepted
     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: NO

    This patch seems to break "Prediffer" menu.

    Index: MainFrm.cpp

    --- MainFrm.cpp (revision 5645)
    +++ MainFrm.cpp (working copy)
    @@ -460,7 +460,7 @@
    // look for "Plugins" menu
    int i;
    for (i = 0 ; i < ::GetMenuItemCount(mainMenu) ; i++)
    - if (::GetMenuItemID(::GetSubMenu(mainMenu, i), 0) == ID_UNPACK_MANUAL)
    + if (::GetMenuItemID(::GetSubMenu(mainMenu, i), 0) == ID_PLUGINS_LIST)
    break;
    HMENU editMenu = ::GetSubMenu(mainMenu, i);

     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: NO

    Also I get compilation error on ANSI build now.

    Index: Plugins.cpp

    --- Plugins.cpp (revision 5645)
    +++ Plugins.cpp (working copy)
    @@ -372,6 +372,8 @@
    */
    static int LoadPlugin(PluginInfo & plugin, const CString & scriptletFilepath, LPCWSTR transformationEvent)
    {
    + USES_CONVERSION;
    +
    // set up object in case we need to log info
    ScriptInfo scinfo(scriptletFilepath, transformationEvent);

    @@ -461,7 +463,7 @@
    scinfo.Log(_T("Plugin had PluginDescription property, but error getting its value"));
    return -60; // error (Plugin had PluginDescription property, but error getting its value)
    }
    - plugin.m_description = ret.bstrVal;
    + plugin.m_description = OLE2T(ret.bstrVal);
    }
    else
    {
    @@ -480,7 +482,7 @@
    scinfo.Log(_T("Plugin had PluginFileFilters property, but error getting its value"));
    return -70; // error (Plugin had PluginFileFilters property, but error getting its value)
    }
    - plugin.m_filtersText= ret.bstrVal;
    + plugin.m_filtersText = OLE2T(ret.bstrVal);
    hasPluginFileFilters = true;
    }
    else

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-21

    Logged In: YES
    user_id=631874
    Originator: YES

    Committed to 2.10 branch (before I noticed your comments - I don't currently get notification mails about new comments...)
    Completed: At revision: 5647

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-21

    Logged In: YES
    user_id=631874
    Originator: YES

    > This patch seems to break "Prediffer" menu.
    Oh, forgot that dynamic menu creation.

    > Also I get compilation error on ANSI build now.
    That can't be related to this patch, probably related to CString to String conversion I did for couple of strings in plugin code. The fix looks good.

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-21

    Logged In: YES
    user_id=631874
    Originator: YES

    > > Also I get compilation error on ANSI build now.

    2.10 branch doesn't have that ANSI build problem. (After committing the patch.)

     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: NO

    >2.10 branch doesn't have that ANSI build problem. (After committing the
    >patch.)

    Yes, it is trunk only problem.
    Committed SVN trunk. Completed: At revision: 5649

    >This patch seems to break "Prediffer" menu.
    Committed SVN trunk. Completed: At revision: 5650
    Committed 2.10 branch. Completed: At revision: 5651

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-21

    Logged In: YES
    user_id=631874
    Originator: YES

    Thanks for committing those fixes.

    Closing this patch item now.

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-21
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.