Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#2423 PO(T) syntax highlighter

Branch_+_Trunk
closed-fixed
nobody
GUI (476)
5
2008-01-08
2008-01-07
Tim Gerundt
No

This patch adds a syntax highlighter for PO(T) files to WinMerge. For the GUI use the patch the name "Portable Object".

Greetings,
Tim

Discussion

  • Kimmo Varis

    Kimmo Varis - 2008-01-07

    Logged In: YES
    user_id=631874
    Originator: NO

    Looks ok.

    But, I only now realized there is a resource string change too. And we won't do them for 2.6 branch! We've never done them for stable branches so that lang files keep working. And it also creates ugly untranslated string translators might not be happy about (as we haven't told them there is something to do..).

    Now, could these (powershell string also) be strings that aren't translated? Can you check if there are translations for these syntax highlight names? If there are, then we have to backout powershell syntax highlighting patch from 2.6 branch. I assume Japanese atleast translates them..

    Sorry, this was my fault that I didn't spot string addition! :(

     
  • Tim Gerundt

    Tim Gerundt - 2008-01-08

    Logged In: YES
    user_id=652377
    Originator: YES

    > But, I only now realized there is a resource string change too.

    Yes, but NOT in 2.6 branch! We have this resource string first since WinMerge 2.7, for selecting the highlighter from the View menu.

    In 2.6 branch only this files get touched:
    * Src\Merge.dsp
    * Src\editlib\ccrystaltextview.cpp
    * Src\editlib\ccrystaltextview.h
    * Src\editlib\powershell.cpp

     
  • Kimmo Varis

    Kimmo Varis - 2008-01-08

    Logged In: YES
    user_id=631874
    Originator: NO

    ARGH! I just don't remember 2.6 features anymore! :( Of course you are right. So just forget my earlier comment and apply to 2.6 branch too.

     
  • Tim Gerundt

    Tim Gerundt - 2008-01-08
    • status: open --> open-accepted
     
  • Tim Gerundt

    Tim Gerundt - 2008-01-08

    Logged In: YES
    user_id=652377
    Originator: YES

    Commited to SVN (Trunk, In Revision 4876 & 4877)...

     
  • Tim Gerundt

    Tim Gerundt - 2008-01-08

    Logged In: YES
    user_id=652377
    Originator: YES

    Commited to SVN (Branch R2_6, In Revision 4878)...

     
  • Tim Gerundt

    Tim Gerundt - 2008-01-08
    • status: open-accepted --> closed-fixed
     

Log in to post a comment.