#2268 patch for RFE:[ 1578806 ] Use icons in MRU list

open
nobody
GUI (476)
5
2007-05-20
2007-05-12
No

SVN trunk rev.4278

This patch implements the feature that was described in http://sourceforge.net/tracker/index.php?func=detail&aid=1578806&group_id=13216&atid=363216

- Uses ComboBoxEx instead of ComboBox.
- Uses SHGetFileInfo function to get icons.
- When adding a path to list, it doesn't get the icon of the file at the same time. It gets icon later in OnGetDispInfo.
- When there is a network path in list, the timeout to wait for the response is one second.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2007-05-19

    Logged In: YES
    user_id=631874
    Originator: NO

    Looks good. I'm only a bit afraid of that network path check.

    As it turns out, in bug #1697905 Full paths shown when just filename should be shown
    http://winmerge/org/bug/1697905
    we can already have URLs as paths...

     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: YES

    Hmm. Now I understand that we have to think about how to treat the case "file://" and the case "http://".

     
  • Takashi Sawanaka

    • labels: --> GUI
     
  • Kimmo Varis

    Kimmo Varis - 2007-05-20

    Logged In: YES
    user_id=631874
    Originator: NO

    I think we can't even restrict it to those two (that Subversion uses). But handling URLs is a huge change and certainly will cause some big bugs and problems.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks