Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#933 Cleaning up Help-menu

closed-fixed
nobody
GUI (348)
5
2008-02-13
2008-01-18
Tim Gerundt
No

As noticed in patch #1852534 we should cleaning the "Help" menu. We have currently the 3 items "Contents", "Index" and "Search" in this menu. All modern programs have only 1 item for the help file.

And we should remove the "..." from items that opens external files and not WinMerge dialogs.

Greetings,
Tim

Discussion

  • Tim Gerundt

    Tim Gerundt - 2008-02-06

    Logged In: YES
    user_id=652377
    Originator: YES

    Ok, this patch remove the "Index" and "Search" items from the "Help" menu.

    File Added: cleaning_up_help_menu_step1.7z

     
  • Tim Gerundt

    Tim Gerundt - 2008-02-06

    Logged In: YES
    user_id=652377
    Originator: YES

    File Added: cleaning_up_help_menu_step1.patch

     
  • Kimmo Varis

    Kimmo Varis - 2008-02-07

    Logged In: YES
    user_id=631874
    Originator: NO

    Looks good. Perhaps I'd use "WinMerge Help" as menuitem text still (seems what few applications I checked use) but "User Manual" is good also.

     
  • Tim Gerundt

    Tim Gerundt - 2008-02-07

    Logged In: YES
    user_id=652377
    Originator: YES

    Committed with "WinMerge Help" to SVN (In Revision 5012).

    Leave open for removing "..." from some items...

     
  • Tim Gerundt

    Tim Gerundt - 2008-02-07
    • status: open --> open-accepted
     
  • Tim Gerundt

    Tim Gerundt - 2008-02-12

    Logged In: YES
    user_id=652377
    Originator: YES

    This patch remove the "..." from the "Configuration" and "GNU General Public License" menu items:

    Index: Merge.rc

    --- Merge.rc (revision 5031)
    +++ Merge.rc (working copy)
    @@ -176,10 +176,10 @@
    MENUITEM SEPARATOR
    MENUITEM "R&elease Notes", ID_HELP_RELEASENOTES
    MENUITEM "&Translations", ID_HELP_TRANSLATIONS
    - MENUITEM "C&onfiguration...", ID_HELP_GETCONFIG
    + MENUITEM "C&onfiguration", ID_HELP_GETCONFIG
    MENUITEM "A&rchive Support disabled...", ID_HELP_MERGE7ZMISMATCH
    MENUITEM SEPARATOR
    - MENUITEM "&GNU General Public License...", ID_HELP_GNULICENSE
    + MENUITEM "&GNU General Public License", ID_HELP_GNULICENSE
    MENUITEM "&About WinMerge...", ID_APP_ABOUT
    END
    END
    @@ -290,10 +290,10 @@
    MENUITEM SEPARATOR
    MENUITEM "R&elease Notes", ID_HELP_RELEASENOTES
    MENUITEM "&Translations", ID_HELP_TRANSLATIONS
    - MENUITEM "C&onfiguration...", ID_HELP_GETCONFIG
    + MENUITEM "C&onfiguration", ID_HELP_GETCONFIG
    MENUITEM "A&rchive Support disabled...", ID_HELP_MERGE7ZMISMATCH
    MENUITEM SEPARATOR
    - MENUITEM "&GNU General Public License...", ID_HELP_GNULICENSE
    + MENUITEM "&GNU General Public License", ID_HELP_GNULICENSE
    MENUITEM "&About WinMerge...", ID_APP_ABOUT
    END
    END
    @@ -475,10 +475,10 @@
    MENUITEM SEPARATOR
    MENUITEM "R&elease Notes", ID_HELP_RELEASENOTES
    MENUITEM "&Translations", ID_HELP_TRANSLATIONS
    - MENUITEM "C&onfiguration...", ID_HELP_GETCONFIG
    + MENUITEM "C&onfiguration", ID_HELP_GETCONFIG
    MENUITEM "A&rchive Support disabled...", ID_HELP_MERGE7ZMISMATCH
    MENUITEM SEPARATOR
    - MENUITEM "&GNU General Public License...", ID_HELP_GNULICENSE
    + MENUITEM "&GNU General Public License", ID_HELP_GNULICENSE
    MENUITEM "&About WinMerge...", ID_APP_ABOUT
    END
    END
    File Added: cleaning_up_help_menu_step2.patch

     
  • Tim Gerundt

    Tim Gerundt - 2008-02-12

    Logged In: YES
    user_id=652377
    Originator: YES

    After noticed by Hans Eriksson I changed "WinMerge help" to "WinMerge Help" in the descripton text.

    Commited to SVN (In Revision 5034).

     
  • Kimmo Varis

    Kimmo Varis - 2008-02-12

    Logged In: YES
    user_id=631874
    Originator: NO

    > This patch remove the "..." from the "Configuration" and
    > "GNU General Public License" menu items:

    Looks good.

     
  • Tim Gerundt

    Tim Gerundt - 2008-02-13
    • status: open-accepted --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2008-02-13

    Logged In: YES
    user_id=652377
    Originator: YES

    Committed to SVN (In Revision 5041)...

     

Log in to post a comment.