#2050 Keeps verifing path even turned off in options

Branch_+_Trunk
closed-fixed
nobody
Usability (119)
5
2010-11-21
2010-11-18
oleav
No

I have turned off "Automatically verify paths in open dialog". Nevertheless WinMerge keeps checking path showing "Left path is invalid" or "Right path is invalid" in Open Dialog. I compare files on network and this makes WinMerge hang up for some time.

I have version 2.12.4.0

Thanks for the great program!

Discussion

  • oleav

    oleav - 2010-11-18

    Configuration log

     
  • Tim Gerundt

    Tim Gerundt - 2010-11-19

    possible patch

     
  • Tim Gerundt

    Tim Gerundt - 2010-11-19

    I think the problem is in COpenDlg::UpdateButtonStates().

    The GetPairComparability() and paths_DoesPathExist() calls must inside the "if (GetOptionsMgr()->GetBool(OPT_VERIFY_OPEN_PATHS))" block. The attached patch fix the problem for me, but remember that I am a C/C++ amateur! ;-)

     
  • oleav

    oleav - 2010-11-19

    Thank you, Tim!

    I'm not ready yet to install C++ compiler & sources, but your patch gives a hope that it will be in alpha version sometime :)

     
  • Kimmo Varis

    Kimmo Varis - 2010-11-20

    Hmm. I wonder why we made it like it is now.. But the patch looks ok.

     
  • Tim Gerundt

    Tim Gerundt - 2010-11-21

    Committed to SVN:

    * In Revision 7437 (Trunk)
    * In Revision 7438 (Branch R2_14)

    Thank you for the bug report oleav. It should be fixed in the next WinMerge release! :)

     
  • Tim Gerundt

    Tim Gerundt - 2010-11-21
    • milestone: --> Branch_+_Trunk
    • status: open --> closed-fixed
     
  • Jochen Tucht

    Jochen Tucht - 2010-11-21

    It is dismaying to reread through bugs item #2705940 after this. Yes it was revision 1449 which did not work as intended. And we have been seriously considering to show a message box that warns users about invalid paths by the time they click OK, and keep the open dialog open in that case, while this has been the exact program behavior for half a decade or so.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks