#2018 copy and advance: toolbar icons not automatically enabled

Branch_+_Trunk
closed-fixed
GUI (515)
5
2010-09-25
2010-07-23
Zhong Qiyao
No

Version: 2.14.4.0 Unicode

1. Use "Next difference" and "Previous difference". After going, the "Copy Right and Advance" and "Copy Left and Advance" buttons are enabled.
This is correct.

2. Now manually position the cursor at a difference. Or use "Edit > Find" to go to a difference. After going, the "Copy Right" and "Copy Left"
buttons are enabled. This is also correct.

3. PROBLEM: After step 2 above, the "Copy Right and Advance" and "Copy Left and Advance" buttons are not automatically enabled.
A similar problem happens for the menu items under "Merge".

4. EXPECTED BEHAVIOUR: After step 2 above, the buttons and menu items mentions in step 3 above will be automatically enabled.

Thanks.

Discussion

  • Zhong Qiyao

    Zhong Qiyao - 2010-07-23

    Version: 2.12.4.0 Unicode <<< correction

     
  • Zhong Qiyao

    Zhong Qiyao - 2010-08-31

    The same thing happens if, when the file opens, it automatically falls on the first difference.

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03

    I added a patch for this, but a real developer should better look over it! :)

     
  • Kimmo Varis

    Kimmo Varis - 2010-09-03

    This got me puzzled for a while and I was already writing a comment that this patch can't work. But luckily I understood your logic before sending that comment. :)

    The idea in current implementation is that caret must be inside the difference so that we can merge the difference. Earlier logic was that the difference must be also selected (and obviously this logic change wasn't fully done).

    So the removal of checking that we are in difference got me wondering. But since you are cleverly using the already working GUI enabling checks the user can't even select these features when not inside difference. Can you double-check that shortcut keys are also disabled?

    If shortcut keys also work I think this patch is OK.

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03
    • status: open --> open-accepted
     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03

    I tested the shortcut keys and they only work if you inside a difference or a difference is selected.

    Is this Trunk only, or should I also port it to Branch R2_12 after a "alpha" version?

     
  • Kimmo Varis

    Kimmo Varis - 2010-09-03

    Thanks, then this patch is OK.

    Is somebody going to release something from 2.12 branch? If not, why bother?

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03

    Committed to SVN (In Revision 7235)...

    Thank you for the bug report!

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03
    • assigned_to: nobody --> gerundt
    • milestone: --> 102450
    • status: open-accepted --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2010-09-25

    patch file for branch R2_14

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-25

    Backported to Branch R2_14:

    Committed to SVN (In Revision 7284)...

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-25
    • milestone: 102450 --> Branch_+_Trunk
     
  • Zhong Qiyao

    Zhong Qiyao - 2011-01-13

    RELATED PROBLEM:

    I finally found the confusion between "selected difference" (in red)
    and "difference at cursor". If you already have a selected difference, then:

    1. Click your mouse to another difference. Now you lose the "selected difference",
    and this new difference is your "current diffence" for copying.

    2. If you move your cursor (by the cursor keys) out of the "selected difference" into
    another difference, there does not seem to be a way to mark your new difference
    (at the cursor) as the "current difference" for copying.

    Thanks.

     
  • Zhong Qiyao

    Zhong Qiyao - 2011-05-06

    CONCERNING THIS ONE:

    <<
    1. Click your mouse to another difference. Now you lose the "selected
    difference",
    and this new difference is your "current diffence" for copying.
    >>

    I found that if you single-click into a difference, you get a current difference (yellow).
    If you double-click a difference, you get a selected difference (red).

    I wonder whether there is a keyboard operation which, if you use the keyboard to
    go to a difference (yellow), you can then use the keyboard to make it a selected
    difference (red).

    Thanks.

    Qiyao

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks