if location pane in focus - enable icon Save(wichout correction file)
The bug reporter means:
If you open two files and don't change the content, the "Save" toolbar icon and menu entires are disabled. This is correct! But if the location pane get the focus, the "Save" items get enabled. This is wrong!
I can reproduce the bug with 2.12.* and 2.13.*.
There is at least one earlier bug open already about this.
patch file for trunk
I added a patch to this item, since I don't find the other bug report after a quick look.
The patch is correct in what it is doing.
One thing I'm wondering is if we really want to allow saving when location pane is selected. User's intention is clear when any file is selected. But is it totally obvious that user wants to save files when location pane is enabled? I it is the most obvious thing user wants to do. So I guess it is ok.
Anyway, current behavior is causing quite a lot of confusion too. So I think this is good fix to go in.
Is disabling the save button a easy fix?
That is another possibility. But I'm wondering if that on the other hand confuses users to think that there are no changes to save... This is a bit tricky topic.
I think I'd prefer your current patch as a fix.
Committed to SVN (In Revision 7236)...
Thank you for the bug report!
patch file for branch R2_14
I backported this bugfix also to Branch R2_14:
Committed to SVN (In Revision 7283)
Log in to post a comment.
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.