#2011 Location pane focus enabled "Save"

Branch_+_Trunk
closed-fixed
None
5
2010-09-25
2010-06-28
No

if location pane in focus - enable icon Save(wichout correction file)

Discussion

  • Tim Gerundt

    Tim Gerundt - 2010-09-02

    The bug reporter means:

    If you open two files and don't change the content, the "Save" toolbar icon and menu entires are disabled. This is correct! But if the location pane get the focus, the "Save" items get enabled. This is wrong!

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-02
    • summary: icon --> Location pane focus enabled "Save"
     
  • Tim Gerundt

    Tim Gerundt - 2010-09-02

    I can reproduce the bug with 2.12.* and 2.13.*.

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-02
    • milestone: --> 438016
     
  • Kimmo Varis

    Kimmo Varis - 2010-09-02

    There is at least one earlier bug open already about this.

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03

    I added a patch to this item, since I don't find the other bug report after a quick look.

     
  • Kimmo Varis

    Kimmo Varis - 2010-09-03

    The patch is correct in what it is doing.

    One thing I'm wondering is if we really want to allow saving when location pane is selected. User's intention is clear when any file is selected. But is it totally obvious that user wants to save files when location pane is enabled? I it is the most obvious thing user wants to do. So I guess it is ok.

    Anyway, current behavior is causing quite a lot of confusion too. So I think this is good fix to go in.

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03

    Is disabling the save button a easy fix?

     
  • Kimmo Varis

    Kimmo Varis - 2010-09-03

    That is another possibility. But I'm wondering if that on the other hand confuses users to think that there are no changes to save... This is a bit tricky topic.

    I think I'd prefer your current patch as a fix.

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03
    • assigned_to: nobody --> gerundt
    • milestone: 438016 --> 102450
    • status: open --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2010-09-03

    Committed to SVN (In Revision 7236)...

    Thank you for the bug report!

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-25

    patch file for branch R2_14

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-25

    I backported this bugfix also to Branch R2_14:

    Committed to SVN (In Revision 7283)

     
  • Tim Gerundt

    Tim Gerundt - 2010-09-25
    • milestone: 102450 --> Branch_+_Trunk
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks