#1835 Compare Window: Difference 4 of 1

Branch_+_Trunk
closed-fixed
GUI (515)
5
2009-01-23
2009-01-08
No

If you use line filters there could be such funny outputs. Problem: Ignored differences are counted in Compare Window, too but shouldn't.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2009-01-08

    Can you be more specific. There can be funny outputs sure, but I think that at least counting is right. I use line filters regularly to ignore line number info in PO files.

     
  • Simon Sobisch

    Simon Sobisch - 2009-01-08

    Enable Line filters and have a files like this (where lf means the line is filtered)

    abc abc
    lfa lfb
    abc abc
    lfa lfb
    abc def

    then use "next difference". Effect: at the right bottom it says difference 3 of 1, buzt should be 1 of 1.

    Can you reproduce this?

     
  • Kimmo Varis

    Kimmo Varis - 2009-01-14

    Thanks, I see it now.

     
  • Kimmo Varis

    Kimmo Varis - 2009-01-14
    • assigned_to: nobody --> kimmov
     
  • Kimmo Varis

    Kimmo Varis - 2009-01-14

    Ok, the bug is in CMergeDoc::OnUpdateStatusNum(). It adds current diff number to statusbar. Which is of course wrong as it contains all diffs. I'm working on a fix..

     
  • Kimmo Varis

    Kimmo Varis - 2009-01-14

    Attaching a patch (SignificantDiffNum.zip).

    File Added: SignificantDiffNum.zip

     
  • Kimmo Varis

    Kimmo Varis - 2009-01-15

    Committed the fix to SVN trunk:
    Completed: At revision: 6330

     
  • Kimmo Varis

    Kimmo Varis - 2009-01-15
    • status: open --> open-fixed
     
  • Kimmo Varis

    Kimmo Varis - 2009-01-23
    • status: open-fixed --> closed-fixed
     
  • Kimmo Varis

    Kimmo Varis - 2009-01-23

    Committed to 2.12 branch:
    Completed: At revision: 6369

    Closing now.

     

Log in to post a comment.