Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#1785 Sub-folder name too-long causes misprint

Trunk
closed-fixed
GUI (515)
5
2008-10-21
2008-09-26
Mark H
No

Version 2.11.1.4 Experimental

Using Folder comparing:
C:\Z\xyz\ with
C:\Z\abc\

subfolders in both branches something like:
zz_mmm\American\ABC\other ideas

Produces a Folder path display of:
zz_mother ideas|mm|AmerABC|ican|
instead of
zz_mmm\American\ABC\other ideas

-----
note:
the folder 'above' "other ideas" displays correctly:
zz_mmm\American\ABC

Discussion

  • Mark H

    Mark H - 2008-09-26
    • summary: Sub-folder name containing space causes misprint --> Sub-folder name too-long causes misprint
     
  • Mark H

    Mark H - 2008-09-26

    Nope...
    Looks like names that are > 10 characters long are also causing it...
    zz_mmm\ARM\Source\Tumbler\obj_noddr_vmax
    produces
    zz_mSouTobj_noddr_vmax|umbler|rce|mm|ARM|

    and
    zz_mmm\ARM\Source\dma_BasicARM produces a correct display...until you add more...
    zz_mmm\ARM\Source\dma_BasicARM\bin
    produces
    zz_mSoudma_Babin|sicARM|rce|mm|ARM|

    ----
    also note, in the Tree display you see the corruption happen in two stages:
    zz_mmm
    -- ARM zz_mmm
    -- Source zz_mmm\ARM
    -- Tumbler zz_mmm\ARM\Source
    -- obj_noddr_vmax zz_mSouTumbler|rce|mm|ARM|
    firstfile.o zz_mSouTobj_noddr_vmax|umbler|rce|mm|ARM|

    and

    zz_mmm
    -- ARM zz_mmm
    -- Source zz_mmm\ARM
    -- dma_BasicARM zz_mmm\ARM\Source
    ARMbasic.c zz_mmm\ARM\Source\dma_BasicARM
    -- bin zz_mSoudma_BasicARM|rce|mm|ARM|
    firstfile.o zz_mSoudma_Babin|sicARM|rce|mm|ARM|

    (I do hope that hammering on these 'Experimental' builds /is/ what you want us to do...? :-)

     
  • Kimmo Varis

    Kimmo Varis - 2008-10-20

    Thanks a lot for reporting this bug. Yes, bug reports from experimental releases are very much welcome! :)

    Yep, I see this too with recursive compare and identical subfolders. It is enough to compare two WinMerge SVN folders (e.g. two releases) recursively.

     
  • Kimmo Varis

    Kimmo Varis - 2008-10-20

    Does not happen with 2.10.0 stable release.

    Looks like it only appears for unique folders in experimental releases. There was a change in experimental releases to recurse inside unique folders (2.10.0 doesn't do that). And that is my suspicion right now - we get long unique paths and that confuses path formatting code.

     
  • Kimmo Varis

    Kimmo Varis - 2008-10-20
    • milestone: --> Trunk
     
  • Kimmo Varis

    Kimmo Varis - 2008-10-20

    This simple patch fixes the bug - don't bother trying to format unique path, just print the existing path.

    Index: DirViewColItems.cpp

    --- DirViewColItems.cpp (revision 6021)
    +++ DirViewColItems.cpp (working copy)
    @@ -209,6 +209,16 @@
    const DIFFITEM &di = *static_cast<const DIFFITEM*>(p);
    String s = di.right.path;
    const String &t = di.left.path;
    +
    + // If we have unique path, just print the existing path name
    + if (s.length() == 0 || t.length() == 0)
    + {
    + if (s.length() == 0)
    + return t;
    + else
    + return s;
    + }
    +
    int i = 0, j = 0;
    do
    {

    File Added: UniqFolders_pathformat.patch

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    Your Thank You is *very* encouraging!
    Thanks.
    I look forward to trying the next build.
    I am using 2.10.0 right now; and good news is I can't break it! :-D

    TTFN (Ta Ta For Now (ala Tigger))

     
  • Mark H

    Mark H - 2008-10-21

    I'm Sorry for the Re-Posts...
    I was reading posts and using the Back arrow...thus causing re-posts I think.
    (Your thank yous /are/ very encouraging; but, I did not mean to cause so much traffic...)

     
  • Kimmo Varis

    Kimmo Varis - 2008-10-21

    Committed the fix to SVN trunk:
    Completed: At revision: 6023

    So the next experimental release will have this bug fixed.

    Closing this bug item now as fixed.

     
  • Kimmo Varis

    Kimmo Varis - 2008-10-21
    • assigned_to: nobody --> kimmov
    • status: open --> closed-fixed
     

Log in to post a comment.