Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#1753 "Syntax Highlight" menu item enabled, if option disabled

Branch_+_Trunk
closed-fixed
GUI (515)
5
2008-08-11
2008-07-25
Tim Gerundt
No

If the option "Editor->Highlight syntax" is disabled, the menu item "View->Syntax Highlight->..." is still enabled. You can select color scheme menu items, but the scheme will not shown (was is correct!).

This behavior is confusing when somebody forgot that he disabled the syntax highlight. He will wonder, why nothing change.

Either we should disable the "Syntax Highlight" menu item or use, if somebody disable the option, the plain color scheme and he can change the color scheme if required.

Greetings,
Tim

Discussion

  • Kimmo Varis

    Kimmo Varis - 2008-07-25

    Logged In: YES
    user_id=631874
    Originator: NO

    Oh, this really behaves weird. Funny that nobody else has noticed this.

    If the syntax highlighting is disabled, we should show "none" as selection, but allow selecting other highlighting style. When user selects other style, we show a messagebox "Syntax highlighting is disabled. Do you want to enable syntax highlighting?". And then enable it if user wants to.

    I think that is what users expect, rather than forcing them to open options dialog just for enabling one option.

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-28

    Logged In: YES
    user_id=631874
    Originator: NO

    Attachinhg simple patch that should be fine for 2.8 branch too. It:
    - disables menuitems for highlight menu if highlighting is disabled
    - sets file type to none if highlighting is disabled
    - resets highlighting type if it was disabled (previously enabled) from options dialog

    File Added: FixSyntaxHLDisabled.zip

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-28

    Patch to reset and disable highlight selections

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-29

    Logged In: YES
    user_id=631874
    Originator: NO

    Patch committed to SVN trunk:
    Completed: At revision: 5699

     
  • Kimmo Varis

    Kimmo Varis - 2008-08-11

    Logged In: YES
    user_id=631874
    Originator: NO

    Committed the fix to 2.10 branch:
    Completed: At revision: 5787

    Closing this bug as fixed.

     
  • Kimmo Varis

    Kimmo Varis - 2008-08-11
    • assigned_to: nobody --> kimmov
    • status: open --> closed-fixed
     

Log in to post a comment.