Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#1654 ShellExtension version resource strings not good

Trunk
closed-fixed
None
5
2008-02-03
2008-01-24
Kimmo Varis
No

2.7.7.3 experimental.

While inspecting my work computer with Sysinternal's Autoruns-tool, I noticed ShellExtension's description texts are not quite correct.

Description: ShellExtension Module
Publisher: missing

These strings are good to be correct so people using tools like Autoruns or otherwise interested about their system know which component it is.

I suggest changing these to:
Description: WinMerge Shell Integration component
Publisher: www.winmerge.org

Hmm. It actually appears Autoruns reads this information from dll version resource. And indeed we haven't updated that properly...

Discussion

  • Kimmo Varis

    Kimmo Varis - 2008-02-01
    • assigned_to: nobody --> kimmov
    • summary: ShellExtension autorun description texts wrong or missing --> ShellExtension version resource strings not good
     
  • Kimmo Varis

    Kimmo Varis - 2008-02-01

    Logged In: YES
    user_id=631874
    Originator: YES

    Updating summary to describe the issue better.

    And assigning to me - this is a must-fix.

     
  • Kimmo Varis

    Kimmo Varis - 2008-02-01

    Logged In: YES
    user_id=631874
    Originator: YES

    I'm going to commit this patch:

    Index: ShellExtension.rc

    --- ShellExtension.rc (revision 4990)
    +++ ShellExtension.rc (working copy)
    @@ -257,17 +257,17 @@
    BLOCK "040904B0"
    BEGIN
    VALUE "Comments", "\0"
    - VALUE "CompanyName", "\0"
    - VALUE "FileDescription", "ShellExtension Module\0"
    - VALUE "FileVersion", "1.13.0.0\0"
    + VALUE "CompanyName", "http://winmerge.org\0"
    + VALUE "FileDescription", "WinMerge Shell Integration library\0"
    + VALUE "FileVersion", "1.13.1.0\0"
    VALUE "InternalName", "ShellExtension\0"
    - VALUE "LegalCopyright", "Copyright 2003-2007\0"
    + VALUE "LegalCopyright", "Copyright 2003-2008\0"
    VALUE "LegalTrademarks", "\0"
    VALUE "OLESelfRegister", "\0"
    VALUE "OriginalFilename", "ShellExtension.DLL\0"
    VALUE "PrivateBuild", "\0"
    - VALUE "ProductName", "ShellExtension Module\0"
    - VALUE "ProductVersion", "1.13.0.0\0"
    + VALUE "ProductName", "WinMerge Shell Integration library\0"
    + VALUE "ProductVersion", "1.13.1.0\0"
    VALUE "SpecialBuild", "\0"
    END
    END

    File Added: shellext_resource.patch

     
  • Kimmo Varis

    Kimmo Varis - 2008-02-03

    Logged In: YES
    user_id=631874
    Originator: YES

    Committed to SVN trunk.
    Completed: At revision: 4991

     
  • Kimmo Varis

    Kimmo Varis - 2008-02-03
    • status: open --> closed-fixed
     

Log in to post a comment.