Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#1566 Line difference highlight creates content

Trunk
closed-fixed
None
7
2007-11-21
2007-10-11
Kimmo Varis
No

WinMerge 2.7.5.3, seen with all 2.7.5.x versions. Config file in attached zip.

Compare ChildFrm.cpp files in zip (in separate subfolders). ChildFrm.cpp in Altered-folder has extra content in first difference, last couple of words have been dublicated.

That content is not in file. It is only in WinMerge view.

This is very confusing situation when one sees this. The additional text cannot be selected, cannot be edited or removed. User simply doesn't know what is going on, and probably doesn't even realize the additional content is not in the actual file.

This is serious bug. And because of this I'm just considering reverting line difference highlight patches since 2.6 branch creation. As I don't know what earlier version would be safe, the 2.6 versions seems the safest one.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2007-10-11

    Test files + config file

     
  • Kimmo Varis

    Kimmo Varis - 2007-10-11
    • priority: 5 --> 7
     
  • Kimmo Varis

    Kimmo Varis - 2007-11-20

    Logged In: YES
    user_id=631874
    Originator: YES

    This bug is not seen in 2.6.12.

    Like earlier mentioned in developers-forum, I'll revert highlighting code to 2.6.12 version. This regression is too bad to have.

     
  • Kimmo Varis

    Kimmo Varis - 2007-11-20

    Logged In: YES
    user_id=631874
    Originator: YES

    Attaching a patch reverting some code to 2.6.12 level.

    I'll commit this to SVN tomorrow.
    File Added: Revert_SyntaxHighlight.zip

     
  • Kimmo Varis

    Kimmo Varis - 2007-11-20
    • assigned_to: nobody --> kimmov
     
  • Kimmo Varis

    Kimmo Varis - 2007-11-21
    • status: open --> closed-fixed
     
  • Kimmo Varis

    Kimmo Varis - 2007-11-21

    Logged In: YES
    user_id=631874
    Originator: YES

    Backout patch committed to SVN trunk.
    Completed: At revision: 4782

    Closing as fixed.

     
  • Kimmo Varis

    Kimmo Varis - 2007-12-20

    Logged In: YES
    user_id=631874
    Originator: YES

    More backout committed to SVN, as discussed in bug item:
    #1748940 LineDiff: WinMerge 2.7.4.0 shows difference wrong
    http://winmerge.org/bug/1748940

     

Log in to post a comment.