#1324 comments not being ignored?

open
nobody
None
2
2006-10-19
2006-09-12
elsapo
No

I'm not sure if this is user error or a blatant (?) bug.

I was going to set up a nice abtruse test of the
comment filtering using CP037, which is an EBCDIC
character set, as a nice test to see if the comment
filtering code is handling character encodings
correctly -- and if not, to have a set of repro files
to help diagnose it.

But, I cannot get it to work in an ASCII-compatible
codeset to start with on my test files, so...

I don't know if I'm doing this all wrong, or if it is
broken on this really simple case. So I'll post this
with files.

The attached zip should have two subdirectories with a
couple files. The files named testcmt.txt are tiny
one-line files with C comments in the middle of their
one line, and they're identical except for the stuff in
the comment.

Side a: 123/*hi*/456
Side b: 123/*hit*/456

I thought that the Edit/Options/Compare/Comments/Filter
Comments would make it ignore that difference. (As I
say, this wasn't my test; this was just a sanity check
on the way to a real test with an unusual character set.)

WinMerge configuration log
--------------------------
...
Version information:
WinMerge.exe: 0.0.0.0
Build config: _DEBUG _MBCS
Windows: Microsoft Windows XP Professional Service
Pack 2 (Build 2600)
~COMCTL32.dll dllversion=5.82 dllbuild=2900
ShellExtension.dll version=0.00 build=0000
ShellExtensionU.dll version=0.00 build=0000

WinMerge configuration:
Compare settings:
Ignore blank lines: No
Ignore case: No
Ignore carriage return differences: Yes
Whitespace compare: Compare all
Detect moved blocks: No
Compare method: 0
Stop after first diff: No

Other settings:
Automatic rescan: No
Simple EOL: Yes
Automatic scroll to 1st difference: No
Backup original file: Yes

Show:
Identical files: Yes
Different files: Yes
Left Unique files: Yes
Right Unique files: Yes
Binary files: Yes
Skipped files: Yes

Editor settings:
View Whitespace: No
Merge Mode enabled: Yes
Show linenumbers: No
Wrap lines: No

Font:
Font facename: Courier New
Font charset: 0 (Ansi)

System settings:
codepage settings:
ANSI codepage: 1252
OEM codepage: 437
multibyte codepage: 0
Locale (Thread):
Def ANSI codepage: 1252
Def OEM codepage: 437
Country: United States
Language: English
Language code: 0409
ISO Language code: en
Locale (User):
Def ANSI codepage: 1252
Def OEM codepage: 437
Country: United States
Language: English
Language code: 0409
ISO Language code: en
Locale (System):
Def ANSI codepage: 1252
Def OEM codepage: 437
Country: United States
Language: English
Language code: 0409
ISO Language code: en
Detect codepage automatically for RC and HTML files: No
unicoder codepage: 1252

Plugins:
Unpackers:
Prediffers:
Editor scripts:

Archive support:
Enable: 1
...

Discussion

  • elsapo

    elsapo - 2006-09-12

    Zip (1KB) of test files, look at testcmt.txt

     
  • Kimmo Varis

    Kimmo Varis - 2006-09-12

    Logged In: YES
    user_id=631874

    Maisonave submitted several patches for comment filtering
    and was very responsive to comments made. Maybe you can send
    him a message and ask? Last time I heard he was busy with work.

    I think that feature has a lot of potential. But GUI needs a
    lot of work. And maybe it still works in wrong layer, I'm
    not sure. But it is also first real step towards (shrug)
    post-filtering (I'm gonna regret I mentioned that word..).

     
  • Kimmo Varis

    Kimmo Varis - 2006-10-19
    • priority: 5 --> 2
     

Log in to post a comment.