#1222 Scroll to the next difference not working if last is large

Trunk
closed-fixed
GUI (515)
5
2006-05-02
2006-04-07
Mark H
No

Version 2.5.3.5
Experimental version.
This version includes some capabilities to handle
"Clear Case" CMS.

Bug:
The "Scroll to the next difference" button or
alt-dwnarrow does not work if the current difference is
very large. It seems that the "large" difference need
only exceed one screen size; however, there may be a
more numeric limit in the code somewhere. The current
file I am testing has a block of code added to the left
file of 39 lines that do not exist in the right file.
This is the simplest way to get a large difference
between files that I can think of.

This is a NEW feature. This limitation has not existed
in previous 'stable' builds.

If you go to the bottom of the file and "Scroll to the
previous difference" the all works well.!.

!!!!!
I shrank the size of my window (vertically) and viola!
it stopped at the next difference that was bigger than
the new smaller screen size!

I hope that helps, if you haven't found it already :-)

Discussion

  • Kimmo Varis

    Kimmo Varis - 2006-04-07
    • milestone: --> Trunk
     
  • Kimmo Varis

    Kimmo Varis - 2006-04-07
    • assigned_to: nobody --> kimmov
     
  • Kimmo Varis

    Kimmo Varis - 2006-04-07

    Logged In: YES
    user_id=631874

    Thanks for reporting this. I'll take a look at fixing.

    Just to be sure, this bug does not happen with stable 2.4.6
    version, right?

     
  • Kimmo Varis

    Kimmo Varis - 2006-04-07

    Logged In: YES
    user_id=631874

    Ok, I think I know what happens.

    There is change in behavior in latest 2.5.x versions. If
    there is no currently selected difference, and user selects
    next/previous difference, we select next difference from top
    of the screen. Not from cursor like in 2.4.x stable versions
    which could have unexpected behavior. Problem (or case I
    didn't think of before) happens when difference has more
    lines than visible in screen.

    I'm not yet sure how we should behave in that case. Two choices:
    - select currently shown big difference
    - select next difference that is not visible

    First may end up scrolling upwards which migh be unexpected
    but is more like 2.4 behavior.

     
  • Kimmo Varis

    Kimmo Varis - 2006-04-17

    Logged In: YES
    user_id=631874

    This should be now fixed in 2.5.3.6 experimental.

     
  • Mark H

    Mark H - 2006-04-28
    • status: open --> open-fixed
     
  • Mark H

    Mark H - 2006-04-28

    Logged In: YES
    user_id=1315443

    Fix verified in 2.5.3.6
    Thank you very much... :D

     
  • Kimmo Varis

    Kimmo Varis - 2006-05-02
    • labels: 104278 --> GUI
    • status: open-fixed --> closed-fixed
     
  • Kimmo Varis

    Kimmo Varis - 2006-05-02

    Logged In: YES
    user_id=631874

    Great! Thanks for verifying it is fixed. I'm closing this
    item now, since it is only problem in one experimental release.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks