#1138 Clicking locationpane doesn't set active compare window

Branch_+_Trunk
open
nobody
GUI (515)
3
2006-02-16
2006-01-22
Kimmo Varis
No

This is present in both CVS trunk and 2.4 branch.

After user clicks location pane with mouse (to goto
into location in file) WinMerge does not show any of
panels as active window. Which looks a bit confusing in
CVS trunk now.

This is now more visible in CVS trunk, but active file
compare pane is lost in 2.4 branch too.

After click-event we call
CLocationView::GotoLocation() which calls
CView::SetFocus() for either panel to set input focus
to panel.

Apparently that doesn't set panel as active window. So
I tried to add CView::SetActiveWindow() call after
SetFocus() call. For my surprise that didn't help either.

I don't have more time to investigate this now, but I
suspect location pane code somehow re-gains active
window status.

Discussion

  • elsapo

    elsapo - 2006-02-01

    Logged In: YES
    user_id=1195173

    In doing PATCH [ 1421199 ] Fix plugin menu for when location
    or diff detail view active

    I found that CChildFrame::GetActiveView returns null after
    I've clicked in the location view. I don't know why. I put a
    comment in mentioning that in the patch, as I go to some
    trouble to find the merge edit view as a result.

    (I don't know if this is relevant, but it sounds like it
    might be.)

     
  • Kimmo Varis

    Kimmo Varis - 2006-02-16
    • priority: 5 --> 3
     
  • Tim Gerundt

    Tim Gerundt - 2008-10-14

    If WinMerge lost the focus (for example switch to a other program) and get it back, the location pane is correct shown a active window.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks