#1110 Suppress "not well formed XML file" messages during compare

Branch_+_Trunk
open
nobody
GUI (515)
5
2014-08-19
2006-01-02
No

It would be helpful to have an option to suppress
warnings about "not well formed XML files".
I often compare trees with thousands of files,
sometimes leaving my desk to let WinMerge do the job in
the meantime. But when I come back, sometimes this
warning makes me angry, because comparing was stopped
at that point and so I always have to stay beside the
compare, to dismiss all the appearing warning dialogs
(if there are any, which I will not know in advance...).

Discussion

  • Kimmo Varis

    Kimmo Varis - 2006-01-03

    Logged In: YES
    user_id=631874

    What is the actual message shown? Yes, we should get rid of
    that kind of message, but currently I've no idea where it
    might be coming? Do you use some plugins?

    Another possibility is to make that dialog non-modal so it
    stays open but compare doesn't stop.

    Directory compare should not show warnings, unless plugins
    are used.

     
  • Bernd Wetzel

    Bernd Wetzel - 2006-01-03

    error dialog box for not well-formed XML files

     
  • Bernd Wetzel

    Bernd Wetzel - 2006-01-03

    Logged In: YES
    user_id=571700

    I attatched the error message.

    After removing the "DisplayXMLFiles.dll" from the plugin
    directory, the error is gone.

     
  • Kimmo Varis

    Kimmo Varis - 2006-01-03

    Logged In: YES
    user_id=631874

    Thanks! After writing my comment I looked at XML plugin and
    indeed there is modal messagebox.

    I'm moving this to bugs-list since this is a bug.

     
  • Kimmo Varis

    Kimmo Varis - 2006-01-03
    • labels: 572065 --> GUI
     
  • Kimmo Varis

    Kimmo Varis - 2006-01-03
    • milestone: --> Branch_+_Trunk
     
  • Kimmo Varis

    Kimmo Varis - 2006-01-03

    Logged In: YES
    user_id=631874

    I think best solution (for 2.5) would be to disallow plugins
    showing messageboxes. Its just stupid to stop folder compare
    because of plugin-related message. Instead plugin should
    return its messages to WinMerge which can show those
    messages after compare is ready. Not as separate
    messageboxes but as a compare log:
    "
    ...
    filexyz.abc could not be opened by plugin cde...
    ...
    "

     
  • elsapo

    elsapo - 2006-01-06

    Logged In: YES
    user_id=1195173

    But, the messageboxes should come up when you are opening
    the files directly -- actually that is the only place I've
    encountered them. So, plugin doesn't know which is
    happening, so plugin has to pass the message to WinMerge,
    which can decide whether to log in (always in the dirscan
    case) or show it (usually in the merge case).

     
  • elsapo

    elsapo - 2006-01-06

    Logged In: YES
    user_id=1195173

    It might be difficult to enable script plugins to call back
    into WinMerge to report errors; I don't know yet.

     
  • Kimmo Varis

    Kimmo Varis - 2006-01-06

    Logged In: YES
    user_id=631874

    Yep. I see three choices:

    1) we add method/param to plugin API telling if plugin is
    called from folder compare or file compare so plugin can
    determing what it can do (for example show messages).
    2) have somekind of callback method plugin can call WinMerge
    core to show those messageboxes in proper time
    3) plugin returns messages to WinMerge core as strings

    Point is plugin must not stop compare progress. There isn't
    anything user can do while comparing since for most cases
    compares take few seconds.

     
  • elsapo

    elsapo - 2006-01-23

    Logged In: YES
    user_id=1195173

    How about adding a property that WinMerge can use to give an
    error log file to the plugin?

    When WinMerge does a directory diff, it can set the error
    log property for all plugins (which have it), but when it
    does a file diff, it doesn't set that property -- so plugin
    is supposed to only report errors interactively if the error
    log property was not et.

    (This is #1 choice on Kimmo's list below 2006-01-06 20:07.)

     

Log in to post a comment.