webwork-user

Re: [Webwork-user] url tag

[<ma...@sm...>]

Hmm. I wasn't aware any change to prevent this. Could
you send me a source file of URLTag that works
correctly so I can diff it?

thx.

-Matt

On Mon, 17 June 2002, "Taavi Tiirik" wrote

> 
> 
> There has been change in url tag behaviour in
revision 1.5 of URLTag.java 
> that disables some useful functionality that was
there in rev. 1.4. Why?
> (Latest rev. is 1.8 that still behaves very similar
to rev. 1.5).
> 
> For example back in rev. 1.4 I could very easily add
url parameters to
> current page like this:
> 
> URL:
> my.action?param1=value1
> 
> code in jsp view:
> <webwork:url>
>   <webwork:param name="'param2'" value="'value2'"/>
> </webwork:url>
> 
> In revision 1.4 this gave me following url:
> 
>     my.action?param1=value1&param2=value2
> 
> Since revision 1.5 it removes any existing url
parameters
> and gives following result:
> 
>     my.action?param2=value2
> 
> I think url tag could use an extra pararameter which
determines
> when parameters have to be added to existing ones and
when
> all current parameters have to be removed. What do
you think?
> 
> with best wishes,
> Taavi
> 
> 
> 
>
_______________________________________________________________
> 
> Sponsored by:
> ThinkGeek at http://www.ThinkGeek.com/
> _______________________________________________
> Webwork-user mailing list
> Web...@li...
>
https://lists.sourceforge.net/lists/listinfo/webwork-user

Re: [Webwork-user] url tag

[<ma...@sm...>]

On recall, We modified the start tag to null params
which was required for WL to work correctly with this.
I did provide a patch and updated CVS. When you get a
chance, take a look at 1.9 and see if this fixes the
problem.

-Matt

On Mon, 17 June 2002, ma...@sm... wrote

> 
> Hmm. I wasn't aware any change to prevent this. Could
> you send me a source file of URLTag that works
> correctly so I can diff it?
> 
> thx.
> 
> -Matt
> 
> On Mon, 17 June 2002, "Taavi Tiirik" wrote
> 
> > 
> > 
> > There has been change in url tag behaviour in
> revision 1.5 of URLTag.java 
> > that disables some useful functionality that was
> there in rev. 1.4. Why?
> > (Latest rev. is 1.8 that still behaves very similar
> to rev. 1.5).
> > 
> > For example back in rev. 1.4 I could very easily add
> url parameters to
> > current page like this:
> > 
> > URL:
> > my.action?param1=value1
> > 
> > code in jsp view:
> > <webwork:url>
> >   <webwork:param name="'param2'" value="'value2'"/>
> > </webwork:url>
> > 
> > In revision 1.4 this gave me following url:
> > 
> >     my.action?param1=value1&param2=value2
> > 
> > Since revision 1.5 it removes any existing url
> parameters
> > and gives following result:
> > 
> >     my.action?param2=value2
> > 
> > I think url tag could use an extra pararameter which
> determines
> > when parameters have to be added to existing ones
and
> when
> > all current parameters have to be removed. What do
> you think?
> > 
> > with best wishes,
> > Taavi
> > 
> > 
> > 
> >
>
_______________________________________________________________
> > 
> > Sponsored by:
> > ThinkGeek at http://www.ThinkGeek.com/
> > _______________________________________________
> > Webwork-user mailing list
> > Web...@li...
> >
>
https://lists.sourceforge.net/lists/listinfo/webwork-user
> 
>
_______________________________________________________________
> 
> Sponsored by:
> ThinkGeek at http://www.ThinkGeek.com/
> _______________________________________________
> Webwork-user mailing list
> Web...@li...
>
https://lists.sourceforge.net/lists/listinfo/webwork-user

Re: [Webwork-user] url tag

[Taavi T. <ta...@ib...>]

Thanks, Matt

1.9 works just fine.

with best wishes,
Taavi

----- Original Message ----- 
From: <ma...@sm...>
To: <ma...@sm...>
Cc: <taa...@ib...>; <web...@li...>
Sent: Monday, June 17, 2002 6:23 PM
Subject: Re: [Webwork-user] url tag


> On recall, We modified the start tag to null params
> which was required for WL to work correctly with this.
> I did provide a patch and updated CVS. When you get a
> chance, take a look at 1.9 and see if this fixes the
> problem.

Re: [Webwork-user] url tag

[Taavi T. <ta...@ib...>]

> On recall, We modified the start tag to null params
> which was required for WL to work correctly with this.
> I did provide a patch and updated CVS. When you get a
> chance, take a look at 1.9 and see if this fixes the
> problem.

Sorry to bring it up again. 1.9 fixed half of this problem.

It does add request parameters *after* these parameters
that are added with <webwork:param> tag. Not good
since this makes it impossible to redefine any allready
existing parameters with <webwork:param> tag.

Better would be to add request parameters in doStartTag()
not in doEndTag as it is done right now. Do you agree?

with best regards,
Taavi

Re: [Webwork-user] url tag

[<ma...@sm...>]

So, the issues is that we don't want to allow
overriding a request param from an internal param tag?
If so, then we can add the request params last to
override any internal param. But, I guess I could see
situations where people might want to override these
params. 

-Matt

On Tue, 18 June 2002, "Taavi Tiirik" wrote

> 
> > On recall, We modified the start tag to null params
> > which was required for WL to work correctly with
this.
> > I did provide a patch and updated CVS. When you get
a
> > chance, take a look at 1.9 and see if this fixes the
> > problem.
> 
> Sorry to bring it up again. 1.9 fixed half of this
problem.
> 
> It does add request parameters *after* these
parameters
> that are added with <webwork:param> tag. Not good
> since this makes it impossible to redefine any
allready
> existing parameters with <webwork:param> tag.
> 
> Better would be to add request parameters in
doStartTag()
> not in doEndTag as it is done right now. Do you agree?
> 
> with best regards,
> Taavi
> 
> 
> 
>
----------------------------------------------------------------------------
>                    Bringing you mounds of caffeinated
joy
>                       >>>     http://thinkgeek.com/sf
   <<<
> 
> _______________________________________________
> Webwork-user mailing list
> Web...@li...
>
https://lists.sourceforge.net/lists/listinfo/webwork-user