[Webwork-devel] ActionSupport log change - why?

[Mike Cannon-B. <mi...@at...>]

G'day guys - me again ;)

On 22/04 ActionSupport changed the way the category object is created, from:

(1.26)
protected transient Category log = Category.getInstance(this.getClass());

to

(1.27)
protected static transient Category log =
Category.getInstance(ActionSupport.class);


Now I don't really care if the log is static or not (ostensibly why the
change was made from the commit message!) but why did we change from
this.getClass() to ActionSupport.class?

Is this a bug?

I hope so! It means that subclasses of ActionSupport now log all their
messages in the webwork.action.ActionSupport category instead of their own
category (ie com.atlassian.blah) unless they override log field with their
own category - which sucks ;)

Looks like an innocent mistake though - or is there a reason for the change
I'm not seeing?

Cheers,
Mike


ATLASSIAN - http://www.atlassian.com
Expert J2EE Software, Services and Support
-------------------------------------------------------
Need a simple, powerful way to track and manage issues?
Try JIRA - http://www.atlassian.com/software/jira