Re: [Webwork-devel] Re: Webwork 1.0.3 / CVS taglib totally broken?

[Mike Cannon-B. <mi...@at...>]

Attached is an AbstractValueStack that fixes one of the NPEs.

I looked into the ValueStack one for ages and I ended up working around it
in my code instead of fixing it - but here's my analysis so far:
- the actual NPE is thrown from inside resin's QPageContext class
- calling context.getRequest() just before context.findAttribute(x) returns
a null, so the problem is obviously that at this point the context's request
object is null
- this only happens when I try to refer to an action from within a component
tag (so it may be the include process loses the request somehow?), let me
explain in pseudo JSP

<ww:action id="foo" />
<ww:select ... list="@foo/list" />

- the call to @foo/list inside the value stack here fails with the NPE
above.

Hope this helps someone else debug it! For now I've removed the reliance on
actions of that piece of code (it now looks in the page action and works
fine)

Hope this helps!

Cheers,
Mike

PS I also had to set valueAttr to null at the end of PropertyTag to get it
to work properly

On 28/5/02 4:21 AM, "Matt Baldree" (ma...@sm...) penned the words:

> I've checked in a Resin 2.1.1 test case that highlights the NPE problem. If
> you click on the test it will work but if you uncomment line 81 in
> tests/test-resin.jsp you will get the NPE. I can't see the problem right now
> so I committed this test case incase anybody else felt motivated to give it
> a look. The test runs fine on other containers so I'm not sure what Resin's
> problem is.
> 
> -Matt
> 
> ----- Original Message -----
> From: "Matt Baldree" <ma...@sm...>
> To: "Sven Kuenzler" <sv...@im...>
> Cc: "Webwork-Developer" <web...@li...>
> Sent: Monday, May 27, 2002 12:41 PM
> Subject: Fw: [Webwork-devel] Re: Webwork 1.0.3 / CVS taglib totally broken?
> 
> 
>> It is happening in both places for Resin 2.1.1. so I don't believe it is a
>> VS problem. I believe it is a tag problem. I'm looking into it.
>> 
>> ----- Original Message -----
>> From: "Sven Kuenzler" <sv...@im...>
>> Newsgroups: gmane.comp.java.webwork.devel
>> To: <web...@li...>
>> Sent: Monday, May 27, 2002 12:13 PM
>> Subject: [Webwork-devel] Re: Webwork 1.0.3 / CVS taglib totally broken?
>> 
>> 
>>> "Mike Cannon-Brookes" <mi...@at...> schrieb im Newsbeitrag
>>> news:B9182255.B7E7%mi...@at......
>>>> PS More investigating (this time in Resin) since I wrote the above -
>> there
>>>> are now a lot of NPEs due to the new ValueStack stuff. Line 96 of
>>>> ValueStack.java and line 403 of AbstractValueStack.java (both probably
>>>> related to null values being looked up and not checked for before
>> calling
>>>> method on the value object)
>>> 
>>> Strange. Both lines you mention are unchanged to the old ValueStack
>> Besides
>>> the fact that some of them now live in an abstract class, that is. Are
> you
>>> sure the NPE's aren't occurring with the old ValueStack as well?
>>> 
>>>     Sven....
>>> 
>>> 
>>> 
>>> 
>>> 
>>> _______________________________________________________________
>>> 
>>> Don't miss the 2002 Sprint PCS Application Developer's Conference
>>> August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm
>>> 
>>> _______________________________________________
>>> Webwork-devel mailing list
>>> Web...@li...
>>> https://lists.sourceforge.net/lists/listinfo/webwork-devel
>>> 
>>> 
>> 
>> 
>> 
>> _______________________________________________________________
>> 
>> Don't miss the 2002 Sprint PCS Application Developer's Conference
>> August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm
>> 
>> _______________________________________________
>> Webwork-devel mailing list
>> Web...@li...
>> https://lists.sourceforge.net/lists/listinfo/webwork-devel
>> 
>> 
> 
> 
> 
> _______________________________________________________________
> 
> Don't miss the 2002 Sprint PCS Application Developer's Conference
> August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm
> 
> _______________________________________________
> Webwork-devel mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/webwork-devel