Re: [Webwork-devel] Webwork 1.0.3 / CVS taglib totally broken?

[<ma...@sm...>]

Alright. Thanks for the reply. We'll get this worked
out and commented accordingly. Whatever the outcome,
I'll check it against Resin, WL, and Tomcat. I'll leave
you and others to check it against Orion. As soon as I
get a thumbs up from the community, I'll release a
patch 1.0.4.

-Matt

On Fri, 24 May 2002, Mike Cannon-Brookes wrote

> 
> Matt,
> 
> Thanks mate - I'll check the CVS in the morning and
report back. I found a
> bunch of changes I needed to make today to get it
working, so I'll see how
> CVS works for me and start from there again tomorrow
(with more mental
> energy).
> 
> Re: release() - this is NOT the preferred method at
all ;)
> 
> Again (yes, I've checked now with the spec and the
author of JSP Tags book)
> release() is called by the container to release
resources associated with
> the tag. It can be called at ANY time the container
wishes (you have no
> guarantee of when it is called). The only restriction
is that it must be
> called before the tag instance is garbage collected.
> 
> So - what you have is lazy programmers (WL, Tomcat
are the two glaring
> examples) who just call release() after every tag
invocation - which leads
> to people's misplaced belief that it MUST be called
everytime. This is not
> so! :) Fast containers (like Resin and Orion) pool
tag instances and reuse
> them (maximising speed), and call release() as few
times as possible
> (sometimes never). I'm sure it's harder to code it
this way, but the end
> result is speed.
> 
> Net result: 
> 
>    NEVER do anything you want to happen in release()!
> 
> This is true across all the JSP tags in WW and other
projects. If you want
> logic to occur, or variables to be reset for each tag
invocation, reset them
> at the end of the doEndTag() method (either before
returning, or as a
> finally block).
> 
> I'll check CVS in the morning - good work on the
quick fixes though!
> 
> Cheers,
> Mike
> 
> On 23/5/02 10:20 PM, "ma...@sm..."
(ma...@sm...) penned the
> words:
> 
> > For WebLogic, using release is the preferred
method. I
> > disagree with your blanket statement. I fixed the
> > release order in the latest CVS and in the branch.
I'm
> > told that it is working correctly on Orion but I'm
> > waiting for official confirmation. I would
appreciate
> > if you could check it with the latest CVS and let me
> > know.
> > 
> > On Thu, 23 May 2002, Mike Cannon-Brookes wrote
> > 
> >> 
> >> Yes - release() is the bane of tag developers.
> >> 
> >> The simple rule is basically - if you're using
> > release, you're doing things
> >> wrong!
> >> 
> >> -mike
> >> 
> >> On 23/5/02 4:28 PM, "Heng Sin Low"
> > (low...@ya...) penned the words:
> >> 
> >>> Ha, finally u got what I mean :)
> >>> 
> >>> Yes, doEndTag should be the right place. I
remember
> >>> Matt have done a massive check in recently that
move
> >>> all this resetting stuff to the release() method.
> >>> 
> >>> Regards,
> >>> Low
> >>> 
> >>>> I'm trying to what out what changes have occurred
> >>> recently, but the taglib
> >>> in CVS is currently broken and not backward
> >>> compatible.
> >>> 
> >>> 
> >>> __________________________________________________
> >>> Do You Yahoo!?
> >>> LAUNCH - Your Yahoo! Music Experience
> >>> http://launch.yahoo.com
> >>> 
> >>> 
> >
_______________________________________________________________
> >>> 
> >>> Don't miss the 2002 Sprint PCS Application
> > Developer's Conference
> >>> August 25-28 in Las Vegas --
> > http://devcon.sprintpcs.com/adp/index.cfm
> >>> 
> >>> _______________________________________________
> >>> Webwork-devel mailing list
> >>> Web...@li...
> >>> 
> >
https://lists.sourceforge.net/lists/listinfo/webwork-devel
> >> 
> >> 
> >> 
> >
_______________________________________________________________
> >> 
> >> Don't miss the 2002 Sprint PCS Application
> > Developer's Conference
> >> August 25-28 in Las Vegas --
> > http://devcon.sprintpcs.com/adp/index.cfm
> >> 
> >> _______________________________________________
> >> Webwork-devel mailing list
> >> Web...@li...
> >> 
> >
https://lists.sourceforge.net/lists/listinfo/webwork-devel
> > 
> > 
> > 
> >
_______________________________________________________________
> > 
> > Don't miss the 2002 Sprint PCS Application
Developer's Conference
> > August 25-28 in Las Vegas --
http://devcon.sprintpcs.com/adp/index.cfm
> > 
> > _______________________________________________
> > Webwork-devel mailing list
> > Web...@li...
> >
https://lists.sourceforge.net/lists/listinfo/webwork-devel