Re: [Webwork-devel] loading log4j.properties

[Mike Cannon-B. <mi...@at...>]

Bill,

Yes - this does make a lot of sense to me and I think I suggested it a while
back (see ServletLoggingDispatcher or something close ;)). It's a trivial
code edition to add an init-param to the dispatcher servlet with the name of
the log4j config file. (If the file ends .xml, use DOMConfigurator,
otherwise use the PropertiesConfigurator).

This is the most elegant solution I think. By default this turns logging off
though (ie no init parameter) which is OK by me. If others don't want this,
perhaps have the string "none" be special to mean turn logging off?

-mike 

8/1/02 3:48 PM, "Bill Burton" <bi...@pr...> wrote:

> Hello,
> 
> Would it make sense to modify the servlet so it takes a Log4J
> configuration parameter?
> 
> - If not specified, logging is assumed to already be initialized.
> - Specify a properties file name
> - Specify an XML file name
> 
> If either a properties file or XML file are specified for the parameter,
> the appropriate one will be used to initialized Log4J.
> 
> -Bill
> 
> Mike Cannon-Brookes wrote:
>> 
>> Matt,
>> 
>> I brought this up a while ago because I have a
>> different issue. I always use xml configuration files
>> in log4j (easier to manipulate, generate etc) and
>> there's no way to do that.
>> 
>> What I'd suggest is abstract the log loading into
>> separate class that's easily extendable. The default
>> behaviour as below is good, and also if log4j is
>> already configured it should not touch it at all. (I
>> configure logging at the EAR level).
>> 
>> -mike
>> 
>> --- Matt Baldree <ma...@sm...> wrote:
>>> I was working on the JSP documentation and realized
>>> we need a configuration
>>> document to describe how to configure WW. I wrote
>>> this today and added it to
>>> CVS. One section in configuration talks about
>>> configuring WW's logger. I
>>> think the developer should be able to substitute the
>>> default
>>> log4j.properties under webwork/ with their own if
>>> they so choose. This means
>>> they could provide a log4j.properties under
>>> WEB-INF/classes that WW would
>>> first check before loading its default under
>>> webwork/. This allows the
>>> developer a clean log4j.properties substitution
>>> without having to
>>> programmatically do it somewhere else. To allow this
>>> capability, I propose
>>> changing the ServletDispatcher as follows:
>>> 
>>> 84c84,92
>>> <
>>> 
>> PropertyConfigurator.configure(classLoader.getResource("webwork/log4j.proper
>>> ties"));
>>> ---
>>>>       try
>>>>       {
>>>> 
>>> 
>> PropertyConfigurator.configure(classLoader.getResource("log4j.properties"));
>>>>          log.info("Custom log4j property file
>>> loaded.");
>>>>       } catch (Exception e)
>>>>       {
>>>> 
>>> 
>> PropertyConfigurator.configure(classLoader.getResource("webwork/log4j.proper
>>> ties"));
>>>>          log.info("Default log4j property file
>>> loaded.");
>>>>       }
>>> 
>>> Thoughts?
>>> 
>>> -Matt
> 
> _______________________________________________
> Webwork-devel mailing list
> Web...@li...
> https://lists.sourceforge.net/lists/listinfo/webwork-devel


Sent using the Entourage X Test Drive.