From: SourceForge.net <no...@so...> - 2004-04-15 21:37:07
|
Patches item #935403, was opened at 2004-04-15 00:23 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=304866&aid=935403&group_id=4866 Category: WebKit Group: None Status: Open Resolution: None Priority: 5 Submitted By: Ken Lalonde (kenlalonde) Assigned to: Nobody/Anonymous (nobody) Summary: Missed storeSession() call in Transaction.py Initial Comment: At the end of a transaction, the (possibly changed) session is not added back to the current SessionStore, so changes are lost. Not good. The attached patch (against today's CVS) fixes it. Btw, it seems to me that it would be reasonable for SessionStore to provide a default storeSession method, using the dictionary metaphor. Subclasses could override, but this default makes sense for most cases: def storeSession(self, session): self[session.identifier()] = session ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=304866&aid=935403&group_id=4866 |
From: SourceForge.net <no...@so...> - 2004-08-26 22:59:33
|
Patches item #935403, was opened at 2004-04-15 00:23 Message generated for change (Comment added) made by gtalvola You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=304866&aid=935403&group_id=4866 Category: WebKit Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Ken Lalonde (kenlalonde) Assigned to: Nobody/Anonymous (nobody) Summary: Missed storeSession() call in Transaction.py Initial Comment: At the end of a transaction, the (possibly changed) session is not added back to the current SessionStore, so changes are lost. Not good. The attached patch (against today's CVS) fixes it. Btw, it seems to me that it would be reasonable for SessionStore to provide a default storeSession method, using the dictionary metaphor. Subclasses could override, but this default makes sense for most cases: def storeSession(self, session): self[session.identifier()] = session ---------------------------------------------------------------------- >Comment By: Geoff Talvola (gtalvola) Date: 2004-08-26 18:59 Message: Logged In: YES user_id=88162 I've checked this into CVS. It fixes the File session store which was broken, but has no effect on the Dynamic or Memory stores which were working properly (and presumably this is why nobody else complained about this being broken -- most people just use the default of Dynamic). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=304866&aid=935403&group_id=4866 |