Re: [Webware-devel] socker error handling bug?

[Christoph Z. <ci...@on...>]

Am 22.05.2019 um 16:05 schrieb Kerrison, Adam:
 > I think the except should be socket.error not select.error … I don’t
 > think accept() will ever raise a select.error? Or perhaps it should
 > catch both select.error and socket.error. self._ignoreErrnos does
 > include ECONNRESET so something is definitely trying to handle it
 >
 > If I’m right it surprises me that no one else has reported similar
 > issues? Or am I totally wrong?

Hi Adam, thanks a lot for reporting this.

I think you're totally right, this should be socket.error, not 
select.error. The former is a subclass of IOError (or OSError in Py3), 
but the latter is a class of its own. And sock.accept() definitely only 
throws the former - I have looked into the source code in socketmodule.c 
to confirm that.

Maybe nobody noticed because errors are normally caught in the select() 
call already or upfront by Apache when connected directly via 
mod_webkit. What is your configuration? apache -> mod_webkit -> nginx as 
load balancer -> appserver? Did changing this line solve your problem?

-- Christoph