Re: [Webware-discuss] Tabs

[Luke Opperman <luke@me...>]

Actually, I have to disagree as the to the meaning. I would argue that in your
example (continuation of line), tabs are still appropriate. The situation the
docs refer to is a case like:
-
x = {
     "bob":   "happy",
     "jane":  "sad",
     "arnie": "indifferent"
    }

In this case, the argument is to use spaces in the inner (past non-tab chars)
alignment (of the dict values), because differences in tabstop settings make
this use not always work to align if the keys have large differences in length.

It's pretty academic though, and I use spaces everywhere anyways...

Luke


> This is talking about a situation like:
> 
> 	x = someFunc(with_lots_of,
> 	             arguments)
> 
> In this case, it should be like:
> 
> <tab>x = someFunc(with_lots_of,
> <tab><spaces.....>arguments)
> 
> I must admit, I have not followed this very closely -- Emacs doesn't 
> work well doing this, and it's only aesthetic.  Dealing with tabs like 
> this only work well for people who aren't using smart editors, and type 
> every tab and space manually.
> 
>    Ian
> 

[Webware-discuss] Tabs

[Jay Love <jsliv@js...>]

> What's your opinion on whether we should use tabs or spaces?

I never really worried about it.  Tabs seem to make more sense to me since then it looks right in the person's editor, whether they like 4 spaces or 8 spaces to represent the tab character.

> 
> I realize people with tabmay 
> look awkward to them because of the large amounts on indentation.

If they have their editor set to Tab on the same page, right? a Tab is just a slash-t in the text file, how the editor chooses to display it is up to it.  When we put in a tab, it's just inserting a slash-t.

> 
> I don't really know how many Python developers use tab
I don't see why this matters, unless we're talking about spaces.

> 

Well, let's open this up for discussion.  I know someone here has a strong opinion against Tabs.  Why? What's the argument for/against?


Jay



> 
> At 07:47 AM 5/31/00 -0400, Jay Love wrote:
> 
> >Just checked in a fixed version of PSPReader.py that should handle
> >that.  Let me know.
> >
> >You're seeing these weird errors because after our tabs versus spaces
> >debate last week, I briefly set my editor to use spaces for indentatino,
> >and then switched back, but every file I had opened got screwed up.
> >I've been fixing them ever since.  I think I've got em all, but one
> >shows up every now and then.
> >
> >Just to confirm, we are using TABS for indentation, right.  And if so,
> >you need to change the ground rules section of the docs, where you say
> >we use tabs, set to 4 spaces.  THat doesn't make any sese, as it doesn't
> >matter what spacing tabs are set to if you're really using tabs.  THat's
> >the point, it may be 4 in yours, but if someone else sets their editor
> >to spaces tabs at 8 spaces, they get to see it their way.
> >
> >Jay
> >
> >
> >Chuck Esterbrook wrote:
> > >
> > > At 11:15 PM 5/30/00 -0400, Jay Love wrote:
> > >
> > > > I never could hook up to CVS, but my committ didn't really change
> > > > anything.
> > > >
> > > > Is PSP working for you?
> > > >
> > > > Jay
> > >
> > > I updated, got this:
> > >
> > > Traceback (innermost last):  File
> > > "C:\ALL\ECHUCK\PROJECTS\WEBWARE\WEBKIT\Application.py", line 220, in
> > > dispatchRequest    self.createServletInTransaction(transaction)  File
> > > "C:\ALL\ECHUCK\PROJECTS\WEBWARE\WEBKIT\Application.py", line 532, in
> > > createServletInTransaction    inst > > > self.getServlet(transaction,path,cache)  File
> > > "C:\ALL\ECHUCK\PROJECTS\WEBWARE\WEBKIT\Application.py", line 473, in
> > > getServlet    inst e
> > > "..\PSP\PSPServletFactory.py", line 115, in servletForTransaction
> > > clc.compile()  File "..\PSP\PSPCompiler.py", line 58, in compile
> > > parser.parse()  File "..\PSP\Parser.py", line 345, in parse    if
> > > checkfunc(self, handler, reader):  File "..\PSP\Parser.py", line 141,
> > > in checkDirective    reader.Advance(len(open))  File
> > > "..\PSP\PSPReader.py", line 244, in Advance    while prog <
> > > length:NameError: prog
> 

[Webware-discuss] Tabs

[Chuck Esterbrook <echuck@mi...>]

Using spaces is problematic if someone throws in some tabs.

Using tabs is problematic if someone throws in some spaces.

So we have to choose one or the other. Tabs are smaller and can be cursored 
through, so we chose tabs. I'd like to stick with them.

-Chuck

[Webware-discuss] Tabs

[Edmund Lian <elian@in...>]

I want to submit a small patch, but I use spaces, not tabs for indentation
(which is not a problem with vim). So, I'll convert the spaces to tabs as
per the Webware styleguide. However, this is as clear as mud to me:

"""
Tabs are not used past initial indentation.
To avoid alignment problems between people who have tabs set to different
widths.
A common use of tabs is to align the values of a dictionary or the right
hand sides of several consecutive assignment statements. There is no
problem when using tabs for indentation, but when they are used past
non-tab characters, the alignment will be skewed when the tab width is
changed (e.g., when a different developer with a different tab width views
the code).
"""

What the first line says to me (but I know it is wrong) is that we should
use tabs for the first indent, and then spaces thereafter. Could someone
clarify what we're supposed to be using for patches? If you have vim
settings that yield the approved indentation style, then so much the
better...

...Edmund.

Re: [Webware-discuss] Tabs

[Ian Bicking <ianb@co...>]

On Saturday, December 14, 2002, at 02:48 PM, Edmund Lian wrote:
> I want to submit a small patch, but I use spaces, not tabs for 
> indentation
> (which is not a problem with vim). So, I'll convert the spaces to tabs 
> as
> per the Webware styleguide. However, this is as clear as mud to me:
>
> """
> Tabs are not used past initial indentation.
> To avoid alignment problems between people who have tabs set to 
> different
> widths.
> A common use of tabs is to align the values of a dictionary or the right
> hand sides of several consecutive assignment statements. There is no
> problem when using tabs for indentation, but when they are used past
> non-tab characters, the alignment will be skewed when the tab width is
> changed (e.g., when a different developer with a different tab width 
> views
> the code).
> """

This is talking about a situation like:

	x = someFunc(with_lots_of,
	             arguments)

In this case, it should be like:

<tab>x = someFunc(with_lots_of,
<tab><spaces.....>arguments)

I must admit, I have not followed this very closely -- Emacs doesn't 
work well doing this, and it's only aesthetic.  Dealing with tabs like 
this only work well for people who aren't using smart editors, and type 
every tab and space manually.

   Ian

Re: [Webware-discuss] Tabs

[Luke Opperman <luke@me...>]

Actually, I have to disagree as the to the meaning. I would argue that in your
example (continuation of line), tabs are still appropriate. The situation the
docs refer to is a case like:
-
x = {
     "bob":   "happy",
     "jane":  "sad",
     "arnie": "indifferent"
    }

In this case, the argument is to use spaces in the inner (past non-tab chars)
alignment (of the dict values), because differences in tabstop settings make
this use not always work to align if the keys have large differences in length.

It's pretty academic though, and I use spaces everywhere anyways...

Luke


> This is talking about a situation like:
> 
> 	x = someFunc(with_lots_of,
> 	             arguments)
> 
> In this case, it should be like:
> 
> <tab>x = someFunc(with_lots_of,
> <tab><spaces.....>arguments)
> 
> I must admit, I have not followed this very closely -- Emacs doesn't 
> work well doing this, and it's only aesthetic.  Dealing with tabs like 
> this only work well for people who aren't using smart editors, and type 
> every tab and space manually.
> 
>    Ian
>