From: <vb...@us...> - 2002-09-26 06:55:09
|
Update of /cvsroot/webnotes/webnotes/themes/phpnet In directory usw-pr-cvs1:/tmp/cvs-serv20913/themes/phpnet Modified Files: theme.css theme_api.php Log Message: - Removed some hard-coded formatting from the theme, and moved it to the theme.css - Removed some styles which were not needed. - Used strict XHTML validator with the phpnet theme output and fixed all errors. (there is only one remaining error in the sample files which uses border="0" for the source forge logo). - Used htmlspecialchars() rather than string_disable_html() and used it for e-mail / note. This is to escape chars like <, >, and hence get no errors from the validator. - Removed strings_disable_html() - #<note id> will now work in the e-mail (title) field. Index: theme.css =================================================================== RCS file: /cvsroot/webnotes/webnotes/themes/phpnet/theme.css,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- theme.css 26 Sep 2002 04:41:53 -0000 1.3 +++ theme.css 26 Sep 2002 06:55:05 -0000 1.4 @@ -15,3 +15,5 @@ div.phpnet .light { background-color: #e0e0e0; } div.phpnet .lighter { background-color: #f0f0f0; } div.phpnet tr { vertical-align: top; } +div.phpnet img { border: 0px; } +div.phpnet table { border: 0px; width: 100%; } Index: theme_api.php =================================================================== RCS file: /cvsroot/webnotes/webnotes/themes/phpnet/theme_api.php,v retrieving revision 1.26 retrieving revision 1.27 diff -u -d -r1.26 -r1.27 --- theme_api.php 26 Sep 2002 04:41:53 -0000 1.26 +++ theme_api.php 26 Sep 2002 06:55:05 -0000 1.27 @@ -62,12 +62,12 @@ echo <<<EOT <div class="phpnet"> - <table summary="" border="0" cellpadding="4" cellspacing="0" width="100%"> + <table summary="" cellpadding="4" cellspacing="0"> <tr class="dark"> <td><small>User Contributed Notes</small><br /><strong>$t_page</strong></td> <td align="right"> - $t_link_start<img src="$add_picture" border="0" width="13" height="13" alt="Add Notes" />$t_link_end - <img src="$help_picture" border="0" width="13" height="13" alt="About Notes" /> + $t_link_start<img src="$add_picture" width="13" height="13" alt="Add Notes" />$t_link_end + <img src="$help_picture" width="13" height="13" alt="About Notes" /> </td> </tr> EOT; @@ -124,12 +124,12 @@ } if ( isset( $t_note_info['id'] ) && ( $t_note_info['id'] != 0 ) ) { - $t_id = '#' . (integer)$t_note_info['id']; + $t_id = (integer)$t_note_info['id']; $t_visibility = ''; if ( NOTE_VISIBLE_ACCEPTED != $t_note_info['visible'] ) { $t_visibility = '(' . note_get_visibility_str( $t_note_info['visible'] ) . ') - '; } - $t_id_view = "<tt>$t_visibility$t_id<br />$t_moderation</tt>"; + $t_id_view = "<tt>$t_visibility#$t_id<br />$t_moderation</tt>"; $t_id_bookmark = "<a name=\"$t_id\"></a>"; } else { $t_id_view = ' '; @@ -160,7 +160,7 @@ <td colspan="2"> $t_id_bookmark - <table summary="" border="0" cellpadding="2" cellspacing="0" width="100%"> + <table summary="" cellpadding="2" cellspacing="0"> <tr class="light"> <td><strong>$t_email</strong><br />$t_date</td> <td align="right">$t_id_view</td> @@ -182,7 +182,7 @@ if ( empty( $p_page_data['prev_page'] ) ) { $t_prev_text = ''; } else { - $t_prev_text = "<img src=\"$prev_picture\" border=\"0\" width=\"11\" height=\"7\" alt=\"" . $p_page_data['prev_page'] . "\" />" . + $t_prev_text = "<img src=\"$prev_picture\" width=\"11\" height=\"7\" alt=\"" . $p_page_data['prev_page'] . "\" />" . link_create( $p_page_data['prev_url'], $p_page_data['prev_page'], true, '', '' ); } @@ -190,7 +190,7 @@ $t_next_text = ''; } else { $t_next_text = link_create( $p_page_data['next_url'], $p_page_data['next_page'], true, '', '' ) . - "<img src=\"$next_picture\" border=\"0\" width=\"11\" height=\"7\" alt=\"" . $p_page_data['next_page'] . "\" />"; + "<img src=\"$next_picture\" width=\"11\" height=\"7\" alt=\"" . $p_page_data['next_page'] . "\" />"; } if ( empty( $t_prev_text ) && empty( $t_next_text ) ) { @@ -210,8 +210,8 @@ echo <<<EOT <tr class="dark"> <td colspan="2" align="right"> - $t_link_start<img src="$add_picture" border="0" width="13" height="13" alt="Add Notes" />$t_link_end - <img src="$help_picture" border="0" width="13" height="13" alt="About Notes" /> + $t_link_start<img src="$add_picture" width="13" height="13" alt="Add Notes" />$t_link_end + <img src="$help_picture" width="13" height="13" alt="About Notes" /> </td> </tr> EOT; @@ -222,7 +222,7 @@ $t_last_updated = date('D, d M Y - G:i:s', $p_page_data['last_updated']); echo <<<EOT <tr class="dark"><td colspan="2"> - <table class="light" border="0" width="100%" cellpadding="0" cellspacing="4"> + <table class="light" cellpadding="0" cellspacing="4"> $t_navigation_row <tr><td align="right" colspan="2"><small>Last updated: $t_last_updated</small></td></tr> </table> |