From: Keats K. <ke...@xa...> - 2006-03-09 16:12:44
|
Alex, I haven't found the time to evaluate these changes, but I have pretty good faith in the unit tests. If they all still pass I say let's put these out there for folks to try. Keats Alex Twisleton-Wykeham-Fiennes wrote: >On Thu 9 March 2006 12:29, Alex Twisleton-Wykeham-Fiennes wrote: > > >>All, >> >>here are the patched files to avoid unrequired FastWriter creation during >>template evaluation. >> >> > >(there is another email to the list before this one that is stuck in the queue >due to the attachments with the patches for the clean unloading of templates. >However, the patches don't overlap each other so the order of application >should not matter) > > > >>Changes:- >> >>- Template >>added in a write(FastWriter,Context) method. This is already present in >>the only implementing class (WMTemplate) so it has no affect other than >>exposing the API to classes that evaluate against the interface. >> >>- IncludeDirective >>- EvalDirective >>Don't pre-cache the results of the sub-template parsing in a String but >>instead get them to write directly out to the FastWriter that is passed >>into the method. This avoids the creation of a FastWriter to handle the >>template evaluation that is not required and which was taking up a load of >>processing time. >> >>Alex >> >> |