From: Keats K. <ke...@xa...> - 2005-05-27 14:04:56
|
I think the JSP tag lib needs to have its own jar, which we can mark as beta code. We can do the same for the Spring stuff. This way we won't hold up the final release of 2.0 or add more dependencies to the core. I agree that sticking stuff in the contrib branch is kind of like sending them into the great bit bucket in the sky -- although Lane's clean up plan should help a lot. I'd like to give the Taglib a different status -- more like a subproject. I agree with Marc that this is a way to give WM wider adoption, now that so many of us are stuck in JSP shops. Maybe the Spring adapter could be a subproject as well -- I haven't delved into that yet. Maybe a general "WM Adapters" subproject could incorporate JSP, Spring, and Struts integration along with any other framework that folks want to support. We could kick off the subproject in conjunction with the WM 2.0 release. Thoughts? Keats Marc Palmer wrote: >>the jsp and spring integration projects would be desireable to include >>in contrib/ >> >> > >Well Keats said to me he thinks it should go in the main tree. I don't >think this stuff should go in contrib because it will languish in >obscurity there. > >However if we introduce new packages: > >org.webmacro.views.jsp >org.webmacro.views.spring > >...the core becomes dependent on some new JARs which -must- be shipped >with the src distro of WM so that you can build it. However the binary >distro probably shouldn't include the JSP API and Spring JARs. > >I am pretty convinced that the JSP and Spring views will widen usage of WM >significantly provided that they (a) are promoted as a new feature and (b) >work well ;-) > >It may be that we want to hold off on these new components until 2.1 as >nobody else has (apart from Keats with JSP taglib) used them. > >However maybe we could include them as experimental in 2.0? The great >thing about Spring is that I can write some unit tests for the Spring view >as part of the WM src tests :) > >I've also got ServletXXBroker patches to submit which add support for >ServletContext + ClassLoder init, required for the JSP and Spring impls. > >Keats volunteered to do the final JavaCC tweaks so that we can boast 2.0 >also has: > >* JSP Taglib support >* Spring View support >* JDK 1.5 compatibility > >...all I've got left to do is commit this stuff once there is a decision >on branch 2.1 or fold into 2.0, and some minor changes to JSP taglib to >incorporate some suggestions from Keats. > >And I just have to say, you guys -have- to get into Spring, it really >rocks in some areas. ESPECIALLY unit testing of your "servlet" controllers >and testing that the WM context has the vars in it that your webapp should >be supplying etc. > > |