From: Marc P. <ma...@an...> - 2005-05-25 09:02:20
|
> > > Cool. What's the broken #macro issue? Not an issue as such now. It was the #mymacro after a " problem. > It should be a very simple change. I just need to get JavaCC set up on > my box again. It would be great if you could, but it really depends on whether there is a new version yet that aviods use of the "enum" reserved word. > I'm a bit hazy on all the details with the DelegatingTemplateProvider > and what the default configuration is, but I believe the default is to > use the ServletBroker to locate templates for web apps. We'll have to > sort all this out for the new Broker. new Broker... do you mean a WM 3 with horrible Broker dependencies removed ;-) > >OK, so what version of servlet.jar should we ship? 2.3? We should name > it > >so and update the build script to use servlet-api23.jar or similar. > > > We might as well stick with the servlet22.jar, unless there is some > reason to change. It's really just for compiling anyway. OK yes. > >Thanks for all that Keats. Feels like we are the last guys in the WM > >office ;-) > > > > > > > :'( Well I'm a die-hard :) I'm seriously considering rewriting most/all of the WM docs, that is our major failing. WM -is- a nicer product than Velocity, but we really need to do the following: 1. Redo pretty much all the documentation, most of the wiki is terribly out of date and not very helpful / disorganised (aren't all wikis!). The Velocity documentation puts us to shame. 2. Make sure all the source has javadocs 3. Eliminate requirement for FastWriters. It's ridiculous that we can only write to an OutputStream or a FastWriter but not a Writer. 4. Remove the dependency on the Broker implementation - we need to allow WM to be configured from nice bean IoC / Dependency Injection container APIs, from XML files or whatever. Forcing the old webmacro.properties mechanism is very old fashioned. 5. Develop a "WM Tools" area on the website for people to submit tools, and include all compatible Velocity tools in there too - if they're beans it should all be fine. Perhaps even a Velocity tool adapter if needed. Why not help people leverage their hard work :) 6. Get clean and simple, well-documented examples, especially for using WM within other web frameworks such as JSP and Spring. I know, it's not much is it ;-) > I finally got your taglib code working last night. (It took me a while > to realize that you had compiled with Java 5.) Ooops sorry, IDE setting. It doesn't need it. > I was playing around with adding a couple of attributes: > > id - to use a label for diagnostic messages. The setter/getter methods > already exist in the superclass, so you just need to add it to the TLD. > > handler - the name of a Handler class to process the template. The > taglib should look up this name to get the Handler implementation and > then call it with the request, response, and tag body. The handler can > be a class name or a config lookup. I haven't quite figured out what > the best place to configure this. > > What do you think? Sounds good - although I'm not sure what you mean by a handler and what it would be used for. I'll do the ID thing now. > Sounds like you need to accept the servers fingerprint. You can use > PUTTY to connect to the server and accept the fingerprint. Then > everything should be cool. OK thanks, I'll try it soon. Cheers |