Re: [Webmacro-devel] Double-logging in Tomcat?

[Eric B. R. <eb...@tc...>]

On Thursday, April 3, 2003, at 07:07  PM, Marc Palmer wrote:
> On Thu, 3 Apr 2003 14:43:49 -0500, <kea...@na...> 
> wrote:
>
>> Awesome, dude!  You rock.
>>
>> I'm curious to see if this fixes Marc's issue as well.
>
> Nope it doesn't AFAICS. Been using the latest source and still getting 
> double logging.
>
> Remember though - I *do* have more than one simulateneous WM instance, 
> each with different settings. It sounds to me like log targets are 
> being added to some static list when this happens and hence doubling 
> the output.

Yep.  You're right about that.  Not sure if this is easily fixed.  The 
LogTargets are not cached, they're created new for every new Broker 
instance.  Only thing I can see is to have some kind of 
LogTargetFactory that holds onto them (w/ WeakReferences of course) and 
returns an existing target if it "looks" the same as the one being 
created.

I can work on this if it sounds logical.

eric


> BTW in case anyone didn't get it from the CVS list, I've committed a 
> minor mod to WMServlet which makes some methods protected instead of 
> private and adds helpers for getting the Error variable name and the 
> Error template. These are required by my webapp which extends 
> WMServlet.
>
> Marc
> -- 
> Marc Palmer
>