RE: [Webmacro-devel] MathTool.random broken?

[<kea...@na...>]

I guess I was just lazy.  There aren't any existing tests for the MathTool
AFAICT.  

I don't know exactly how to do a test case for random() -- since we
obviously don't know what the expected result is.  I suppose I could loop a
bunch of times and make sure that all values returned are in range and that
all values in the range get returned, or I could just compute the
min/max/mean and check them.  But this seems like overkill for such a simple
(one-line) method.  

The main method I added allows you to do a quick visual check that the thing
is working.  This is better than what we had before.

Keats

> -----Original Message-----
> From: Lane Sharman [mailto:la...@op...]
> Sent: Friday, March 28, 2003 10:22 AM
> To: Keats Kirsch
> Cc: web...@li...; jim...@ag...;
> EricB. Ridge
> Subject: Re: [Webmacro-devel] MathTool.random broken?
> 
> 
> Why did you not add a test case?
> 
> -Lane
> 
> Keats Kirsch wrote:
> 
> > I've committed this change along with a little test in main().
> >
> > Keats
> >
> > Eric B. Ridge wrote:
> >
> >> On Thursday, March 27, 2003, at 11:29  AM, 
> kea...@na...
> >> wrote:
> >>
> >> > > I may fail to understand the code, but it seems wrong to me
> >> > > so I changed it to
> >> > >
> >> > > public static final int random(int start, int end) {
> >> > >       int iRet = start + (int) ((end - start +
> >> > > 1)*java.lang.Math.random());
> >> > >       return iRet > end ? end : iRet;
> >> > > }
> >> >
> >> > Your code looks right to me, but the final test is 
> unnecessary, since
> >> > Math.random() is always less than 1.0.
> >> >
> >> > Eric, I think this was your thing.  Do you want to do the fix, or
> >> > shall I?
> >>
> >> If you're in the mood, go ahead.  :)  I'm snowed under here at the
> >> office.
> >>
> >> eric
> >>
> >
> >
> >
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by:
> > The Definitive IT and Networking Event. Be There!
> > NetWorld+Interop Las Vegas 2003 -- Register today!
> > http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
> > _______________________________________________
> > Webmacro-devel mailing list
> > Web...@li...
> > https://lists.sourceforge.net/lists/listinfo/webmacro-devel
> >
> 
> -- 
> Lane Sharman
> Learn About Conga, All Java GUI Builder: http://opendoors.com/conga
> Java Software Portal: http://opendoors.com
> 
> 
> 
>