Re: [Webmacro-devel] MathTool.random broken?

[Eric B. R. <eb...@tc...>]

On Thursday, March 27, 2003, at 09:50  PM, Keats Kirsch wrote:

> I've committed this change along with a little test in main().

There's actually a .testRandom() method in the test suite.  I don't 
remember exactly which TestCase tho.

eric

>
> Keats
>
> Eric B. Ridge wrote:
>
>> On Thursday, March 27, 2003, at 11:29  AM, 
>> kea...@na...
>> wrote:
>>
>> > > I may fail to understand the code, but it seems wrong to me
>> > > so I changed it to
>> > >
>> > > public static final int random(int start, int end) {
>> > >       int iRet = start + (int) ((end - start +
>> > > 1)*java.lang.Math.random());
>> > >       return iRet > end ? end : iRet;
>> > > }
>> >
>> > Your code looks right to me, but the final test is unnecessary, 
>> since
>> > Math.random() is always less than 1.0.
>> >
>> > Eric, I think this was your thing.  Do you want to do the fix, or
>> > shall I?
>>
>> If you're in the mood, go ahead.  :)  I'm snowed under here at the
>> office.
>>
>> eric
>>
>
>
>