RE: [Webmacro-devel] org.webmacro.util.Clock + Logging

[<kea...@na...>]

> > Clock is only used in 3 places:  o.wm.servlet.ServletLog, 
> > o.wm.util.LogFile, and o.wm.util.LogSource
> >
> > Can I remove this?  Please?
> 
> If I recall, this really was introduced due to heavy 
> performance penalties. 
> I think not using means getting very poor (unrealistic) 
> performance while 
> debugging, and this could in turn foul up your plans if your 
> debugging 
> involves an element of profiling.
> 
> I may be wrong, but I remember this...

I remember this as well.  I think it was Brian who pointed out that using
the System.currentTimeMillis() is really slow.  But it seems like managing a
separate thread just for logging is a bit overkill.  If this is primarily
useful for benchmarking maybe we can have this be a (yet another)
configurable option.  E.g., 

# Enabling the clock thread makes logging timestamps more efficient, but
introduces
# an extra thread.  It may be useful when using logging for performance
metrics.
UseClockThread: false

_______________________________________
Keats Kirsch
Senior Technology Advisor
NatureServe (http://www.natureserve.org)
email: kea...@na...
phone: (703)908-1895