From: Alex F. <al...@fi...> - 2011-11-29 22:57:56
|
On 29 November 2011 22:42, Guy Bolton King <gu...@wa...> wrote: > > On 29 Nov 2011, at 22:27, Tim Pizey wrote: > > <snip> > > What would matter to me is ensuring that this latest bug fix was > > included in any future release. > > Ah, I see. Is there anything in this new arrangement that would prevent > this from happening? > > The only issue is if other things that I have done since I clone Guy's repository wouldn't want to be included in any release. However, I will go through what I have done and make sure that there is nothing contentious (I wasn't necessarily working on the assumption that I was in "the public eye", more just getting re-familiar as to where things were and how they fitted together). From a quick glance against https://github.com/alex-fiennes/webmacro/commits/master I would say that things that "might" be an issue is: https://github.com/alex-fiennes/webmacro/commit/a7a41708f78b089f586311a8dc633cb133883e73- as there may be 3rd party code that is calling the deprecated methods that I've stripped out. https://github.com/alex-fiennes/webmacro/commit/70280ea1043728a8e0aed2cc06bdbc85ddd36368- primarily because it was a first draft of adding in generics information. It all compiles fine and I haven't changed any functionality, but that doesn't mean that it is "right" I'll publish the fix to EvalDirective against both my github version and against the CVS tree and we can work out where we are going to move forwards and whichever course of action we take then we can haven't closed any doors. It will only be a 2 line diff at most. There is an email on list about courses of actions if anyone has any opinions on it... Alex > Regards, > > Guy. -- Alex Fiennes email: al...@fi... mobile: +44 (0)7813 832662 office: +44 (0)1875 823 310 |