[WebMacro-cvs] webmacro checkstyleSuppressions.xml, 1.4, 1.5 checkstyle.xml, 1.6, 1.7

[Tim P <ti...@us...>]

Update of /cvsroot/webmacro/webmacro
In directory sc8-pr-cvs9.sourceforge.net:/tmp/cvs-serv10068

Modified Files:
	checkstyleSuppressions.xml checkstyle.xml 
Log Message:
Done, remaining issues are issues to be investigated.

Index: checkstyleSuppressions.xml
===================================================================
RCS file: /cvsroot/webmacro/webmacro/checkstyleSuppressions.xml,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -d -r1.4 -r1.5
*** checkstyleSuppressions.xml	20 Mar 2008 16:05:14 -0000	1.4
--- checkstyleSuppressions.xml	20 Mar 2008 23:49:14 -0000	1.5
***************
*** 14,18 ****
                files="Test*.java" />
  
!     <!-- Generated by javacc - not in our control -->
      <suppress checks="InnerAssignment"
                files="ASCII_CharStream.java" />
--- 14,18 ----
                files="Test*.java" />
  
!     <!-- Generated by javacc - not under our control -->
      <suppress checks="InnerAssignment"
                files="ASCII_CharStream.java" />
***************
*** 39,43 ****
      <suppress checks="MissingSwitchDefault"
                files="WMParser_implTokenManager.java" />
-               
      <suppress checks="FileLength"
                files="WMParser_impl.java" />
--- 39,42 ----
***************
*** 56,61 ****
--- 55,79 ----
      <suppress checks="TypeName"
                files="WMParser_impl.java" />
+     <suppress checks="RedundantThrows"
+               files="WMParser_impl.java" />
+     <suppress checks="MissingSwitchDefault"
+               files="WMParser_impl.java" />
+     <suppress checks="SimplifyBooleanExpression"
+               files="WMParser_impl.java" />
+     <suppress checks="SimplifyBooleanReturn"
+               files="WMParser_impl.java" />
+     <suppress checks="EmptyForIteratorPad"
+               files="WMParser_impl.java" />
+     <suppress checks="HiddenField"
+               files="WMParser_impl.java" />
+     <suppress checks="ParenPad"
+               files="WMParser_impl.java" />
+     <suppress checks="InnerAssignment"
+               files="ParseException.java" />
+ 
      <suppress checks="TypeName"
                files="WMParser_implConstants.java" />
+     <suppress checks="InterfaceIsType"
+               files="WMParser_implConstants.java" />
  
      <!-- The code is clear -->
***************
*** 71,75 ****
      <suppress checks="TypeName"
                files="CGI_Impersonator.java" />
!               
  
  </suppressions>
--- 89,105 ----
      <suppress checks="TypeName"
                files="CGI_Impersonator.java" />
! 
!     <!-- We want to allow extension -->
!     <suppress checks="FinalClass"
!               files="HTMLEscaper.java" />
!     <suppress checks="FinalClass"
!               files="CheckTemplates.java" />
! 
!     <!-- Not a Utility class ? -->
!     <suppress checks="HideUtilityClassConstructor"
!               files="Expression.java" />
!     <suppress checks="HideUtilityClassConstructor"
!               files="DirectiveDescriptor.java" />
! 
  
  </suppressions>

Index: checkstyle.xml
===================================================================
RCS file: /cvsroot/webmacro/webmacro/checkstyle.xml,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** checkstyle.xml	20 Mar 2008 15:46:48 -0000	1.6
--- checkstyle.xml	20 Mar 2008 23:49:14 -0000	1.7
***************
*** 211,215 ****
              <property name="message" value="Line has trailing spaces."/>
          </module -->
!         <module name="TodoComment"/>
          <module name="UpperEll"/>
  
--- 211,216 ----
              <property name="message" value="Line has trailing spaces."/>
          </module -->
!         <!-- we just use Maven's tag list now -->
!         <!-- module name="TodoComment"/ -->
          <module name="UpperEll"/>