css layout
Brought to you by:
andrewsimpson
The pages were laid out using a table. With the
supplied patches and stylesheet, the pages are laid out
with css without any changes on the rendered page. This
can be a first step towards eliminating tables where
they are not needed.
Note: I had to change create_bottom() to accept
$page_type as argument. I didn't change the
create_bottom() calls though. As a result, if the
$page_type is not 0, an extraneous </div> will be
printed. It will cause no problems though, because
there is no matching opening <div> for it.
patches for css layout
Logged In: YES
user_id=523452
Thank you. I have wanted to change the layout to CSS for a
while, but never been confident about doing it successfully.
The patch works fine with Firefox/Mozilla and Konqueror.
When I tried IE 5.0, it didn't work. The login screen was
hard left; ordinary pages rendered with the main box below
the menu box. I haven't tried IE5.5 or IE6 (they aren't on
this machine).
I spent a while playing around, but I couldn't seem to fix
this behaviour. Interestingly though, I found this page:
http://css-discuss.incutio.com/?page=TwoColumnFloat
It seems very similar, and renders fine in IE5.
Logged In: YES
user_id=336526
I have checked the patches with IE6 and they work fine. I
wouldn't have submitted them otherwise :-) I will try to get
hold of an IE5 machine, resolve the problems there and send
new patches.
Logged In: YES
user_id=523452
O.K. I think it's a IE5 bug :(
In default.css the TABLE.tablebox has 'width : 97%'. This
causes the table to expand to 97% of the entire screen. (I
can verify this by removing the line, or reducing width to
low values).
Some interesting stuff here:
http://nemesis1.f2o.org/aarchive?id=11
I think it is the "100%-wide element in widthless container"
problem.
Logged In: YES
user_id=336526
I knew that it was an IE5 bug. IE5 does not alway play well
with css. Did you managed to fix the css to work with IE5?
If you didn't and we want that IE5 support, I'll try to get
it done next week.
Logged In: YES
user_id=523452
No, I managed to verify the problem (by progressively
deleting lines of code until it worked) and then gave up.
Help would be appreciated. I've seen a few web page
comments, but they look fairly crude.