[Webcampak-users] Minor bug report

[Mark W. <ma...@vo...>]

Hello,

I found a bug in wpakCapture.py at approx line 227 when 
capture-failed.jpg does not exist.

Proposed solution below.
1. check for file
2. add config so that storing failed capture images is optional


                         #modification. 'cfgerroraddfailedpicture' added 
as generally we dont want extra images
                         #warning.  if capture-failed.jpg is not found 
then an error occurs
                         file = self.Cfglocalemessagesdir + 
"capture-failed.jpg", self.Cfgtmpdir + self.Cfgfilename
                         if self.C.getConfig('cfgerroraddfailedpicture') 
== "yes" and os.path.isfile(file):
                             shutil.copy(file)    # Copy specific failed 
picture to tmp directory to be processed similar to a successful capture
                             i = ImageMagick(self.Cfgtmpdir + 
self.Cfgfilename, self.G, self.Debug)    # Create ImageMagick object 
with source filename
                             Capture.ProcessFailedCapture(self, i, 
self.Cfgnow, True)    # Process failed capture (picture process only)
                         self.CaptureManagement.CaptureFailure()     # 
Actions to be started after a failed capture (send an email and/or 
restart camera)
                         self.CaptureManagement.Purge(self.Cfgnow)     
     # Purge tmp directory, delete old pictures after X days or over XX 
MB global size
                 elif CaptureSuccess == True and 
self.C.getConfig('cfgsourcetype') != "ipcam" and 
self.C.getConfig('cfgsourcetype') != "sensor":    # If capture is 
successful and capture is not an ipcam (specific processing)



Regards

Mark
____________________________________________________________

* CONFIDENTIALITY, PRIVACY, COPYRIGHT AND SECURITY NOTICE * 

This mail is confidential to the addressee only and any other use of it is unauthorised. If you are not the addressee and you receive it by accident or otherwise please destroy it and notify the sender of such. To act on it or disseminate any of its contents on an unauthorised basis may be a criminal offence and you leave yourself open to prosecution. All the material in this email is Copyright. The presence of this notice applies to all parts of this entire email whether those elements pre or post date the insertion of this message. This mail has been scanned and was free of viruses and harmful objects when dispatched. Great care has been taken to try and reassure you that this email is genuine.

___________________________________________________________